Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add ChronoModel to the DbConsole adapters list #14218

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

vjt commented Feb 27, 2014

ChronoModel http://github.com/ifad/chronomodel implements temporal extensions for ActiveRecord. As it decorates many migration methods, it defines a new adapter inheriting from the PostgreSQLAdapter.

However, as the Rails console command does not need to load any gem, there is no way for CM to hook into the dbconsole config, and adding it to the hardcoded list is necessary.

@vjt vjt Add ChronoModel to the DbConsole adapters list
ChronoModel http://github.com/ifad/chronomodel implements temporal extensions for ActiveRecord. As it decorates many migration methods, it defines a new adapter inheriting from the PostgreSQLAdapter.

However, as the Rails console command does not need to load any gem, there is no way for CM to hook into the dbconsole config, and adding it to the hardcoded list is necessary.
6819ab3

@vjt vjt referenced this pull request in ifad/chronomodel Feb 27, 2014

Open

The `rails db` command is broken #15

Member

senny commented Feb 27, 2014

@vjt thanks for your work. Third party stuff does not belong into the Rails code. However I see your need for external control. We should look for a solution to make this behavior available through the adapter. This will allow third party adapters to provide their own implementation.

vjt commented Feb 27, 2014

@senny your reply makes total sense. I think these commands should lie within the adapter themselves, and DbConsole should then leverage this new API they provide.

Do you want me to try cooking a patch for the adapters provided with AR?

Member

senny commented Feb 27, 2014

@vjt sure, please go ahead and update this PR when you are ready. 💛

Member

arthurnn commented Mar 18, 2014

@vjt Should we close this PR, and when you ready you send a new one with a reference to this?

vjt commented Mar 18, 2014

if you need to clean up issues, feel free to do so. I haven't had the necessary time to set up everything to code and test this properly. 😄

~Marcello

~ vjt@openssl.it
~ http://sindro.me/

On 18 Mar 2014, at 19:21, Arthur Nogueira Neves notifications@github.com wrote:

@vjt Should we close this PR, and when you ready you send a new one with a reference to this?


Reply to this email directly or view it on GitHub.

Member

senny commented Apr 14, 2014

I'm closing this out of inactivity. Would be great if you find the time to submit a new PR with the discussed changes. Thank you for your time 💛

@senny senny closed this Apr 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment