Setting an ill-formatted Time-ish String into a TimeZone aware column raises an ArgumentError #14253

Closed
wants to merge 1 commit into from

5 participants

@amatsuda
Ruby on Rails member

Giving a Date._parseable but invalid DateTime-ish String value into a TimeZone aware AR column immediately raises since 4.0.x.

This regression was caused by 41ff6a1 which stopped rescuing errors when parsing.

This patch brings back the AR3 behaviour that sets nil in such case instead of raising.
/cc @pixeltrix

@arthurnn
Ruby on Rails member

I guess this is a dup of #11867

@tomkadwill

@amatsuda looks like this bug is being addressed in #11867. Any reason to keep it open or can we close the issue?

@amatsuda amatsuda closed this Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment