Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add documentation for original_fullpath. #14291

Merged
merged 1 commit into from Mar 12, 2014

Conversation

Projects
None yet
4 participants
Contributor

laurocaetano commented Mar 5, 2014

Simple patch to add a documentation for original_fullpath.

@senny senny and 2 others commented on an outdated diff Mar 6, 2014

actionpack/lib/action_dispatch/http/request.rb
@@ -152,6 +152,12 @@ def headers
Http::Headers.new(@env)
end
+ # Returns the +String+ original full path.
@senny

senny Mar 6, 2014

Member

this should probably explain what the ORIGINAL_FULLPATH is. Otherwise it does not really provide any useful information.

@arthurnn

arthurnn Mar 11, 2014

Member

👍 with @senny . You can base your statement from what the build_original_fullpath method is doing, https://github.com/rails/rails/blob/master/railties/lib/rails/application.rb#L405

@laurocaetano

laurocaetano Mar 11, 2014

Contributor

Thanks for your review guys ❤️
I didn't have the time to work on it yet, but I'll do it tonight.

@laurocaetano laurocaetano commented on the diff Mar 11, 2014

actionpack/lib/action_dispatch/http/request.rb
@@ -152,6 +152,13 @@ def headers
Http::Headers.new(@env)
end
+ # Returns a +String+ with the last requested path including their params.
@laurocaetano

laurocaetano Mar 11, 2014

Contributor

Updated the PR.
I didn't explain what ORIGINAL_FULLPATH means, just explained what the method returns, not sure if it's a good improvement for the documentation tho :(

@senny

senny Mar 12, 2014

Member

looks good.

senny added a commit that referenced this pull request Mar 12, 2014

Merge pull request #14291 from laurocaetano/doc-for-original-fullpath
Add documentation for original_fullpath. [ci skip]

@senny senny merged commit 7bbdb07 into rails:master Mar 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment