Make sure we clean preview_interceptors #14326

Merged
merged 1 commit into from Mar 8, 2014

Projects

None yet

3 participants

@arthurnn
Ruby on Rails member

backport #14318 to 4-1 .

I am 95% that this fixed the mailer issue on travis.

travis is now failing randomly for another reason:

1) Error:
MemCacheStoreTest#test_deserializes_unloaded_class:
ArgumentError: key cannot be blank

So we should backport this to 4-1-stable. cc @pixeltrix

@arthurnn arthurnn Make sure we clean preview_interceptors
We should make sure we clean preview_interceptors after each test so they dont leaky to the next test
3ac2aea
@robin850
Ruby on Rails member

With current master I personally still have this random failure (see this gist). :-(

@spastorino
Ruby on Rails member

Anyway seems 👍 to have this in

@spastorino spastorino merged commit 9f559b0 into rails:4-1-stable Mar 8, 2014

1 check passed

Details default The Travis CI build passed
@arthurnn arthurnn deleted the arthurnn:backport_14318 branch Mar 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment