Enhance readability of ActionView DateHelper#distance_of_time_in_words #14334

Merged
merged 1 commit into from Mar 10, 2014

Conversation

Projects
None yet
3 participants
Contributor

kennym commented Mar 10, 2014

Refactor numerical constants to module constants which give the numbers
a contextual meaning. This commit aims to provide quicker understanding
for part of the implementation of the
DateHelper#distance_of_time_in_words method.

Enhance readability of ActionView DateHelper#distance_of_time_in_words
Refactor numerical constants to module constants which give the numbers
a contextual meaning. This commit aims to provide quicker understanding
for part of the implementation of the
DateHelper#distance_of_time_in_words method.
Member

arthurnn commented Mar 10, 2014

I am 👍 with the changes. Someone else, thoughts?

chancancode added a commit that referenced this pull request Mar 10, 2014

Merge pull request #14334 from kennym/master
Enhance readability of ActionView DateHelper#distance_of_time_in_words

@chancancode chancancode merged commit 740862a into rails:master Mar 10, 2014

1 check passed

default The Travis CI build passed
Details
Member

chancancode commented Mar 10, 2014

👍 Thanks!

Contributor

kennym commented Mar 10, 2014

Awesome! Thanks for getting to this so quick. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment