Remove superfluous TODO comment #14340

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@kennym
Contributor
kennym commented Mar 10, 2014

The desired behavor as described in @wycats's TODO comment has been
already implemented. This commit aims to enhance readability by removing
the comment.

@kennym kennym Remove superfluous TODO comment
The desired behavor as described in @wycats's TODO comment has been
already implemented. This commit aims to enhance readability by removing
the comment.
223b580
@arthurnn
Member

As far as I can tell, we are not doing what the TODO says. TODO says we need to validate if the parameters are UTF-8, and we are only converting them to be UTF-8. So I am not sure if we should remove the TODO or not...
@spastorino thoughts?

@kennym kennym closed this Apr 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment