Add Public Api for Register New Extensions for Rake Notes#14379
Add Public Api for Register New Extensions for Rake Notes#14379guilleiguaran merged 8 commits intorails:masterfrom
Conversation
There was a problem hiding this comment.
typo: regiter => register
|
Please add tests |
There was a problem hiding this comment.
Maybe you don't need defaults, you can just use the register method to create all defaults, wdyt?
There was a problem hiding this comment.
sounds good 👍
|
we will need test cases. |
|
done, i guess 😄 |
There was a problem hiding this comment.
are these all extensions supported by default? What about yml for example?
There was a problem hiding this comment.
Right, I removed all the extensions that can be added in the corresponding gems. I'm going to add the support for yml 👍
There was a problem hiding this comment.
Also I missed up .ruby extension
… we have an API for register it in the corresponding gems
|
@robertomiranda : Thanks for your contribution! It looks like your tests are failing though. Would you mind having a look ? Could you also add a changelog entry please ? Also I don't know what do you guys think but I also thought about adding such feature for a while but at the railtie level. What do you think about providing a wrapper around config.annotations.register_extensions("coffee") do
/regex/
end |
There was a problem hiding this comment.
We should keep scss and sass
There was a problem hiding this comment.
Nevermind, this will be sass-rails job.
|
👍 for @robin850 idea. |
|
@robin850 👍 for the wrapper. I'm going to review the tests |
|
railties/CHANGELOG.md
Outdated
There was a problem hiding this comment.
can we update it to:
Add public API to register new extensions for
rake notes.
There was a problem hiding this comment.
Would be good to add an example on how to register new stuff, and maybe a guides update if we have something about rake notes in there.
|
All done |
Add Public Api for Register New Extensions for Rake Notes
|
Thanks!!! |
ref #14214