Skip to content

Add Public Api for Register New Extensions for Rake Notes#14379

Merged
guilleiguaran merged 8 commits intorails:masterfrom
robertomiranda:rake-notes.config
Mar 17, 2014
Merged

Add Public Api for Register New Extensions for Rake Notes#14379
guilleiguaran merged 8 commits intorails:masterfrom
robertomiranda:rake-notes.config

Conversation

@robertomiranda
Copy link
Contributor

ref #14214

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: regiter => register

@guilleiguaran
Copy link
Member

Please add tests

/cc @carlosantoniodasilva @rafaelfranca @senny

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you don't need defaults, you can just use the register method to create all defaults, wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good 👍

@senny
Copy link
Member

senny commented Mar 14, 2014

we will need test cases.

@robertomiranda
Copy link
Contributor Author

done, i guess 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these all extensions supported by default? What about yml for example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I removed all the extensions that can be added in the corresponding gems. I'm going to add the support for yml 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I missed up .ruby extension

@robin850 robin850 added this to the 4.2.0 milestone Mar 15, 2014
@robin850
Copy link
Member

@robertomiranda : Thanks for your contribution! It looks like your tests are failing though. Would you mind having a look ? Could you also add a changelog entry please ?

Also I don't know what do you guys think but I also thought about adding such feature for a while but at the railtie level. What do you think about providing a wrapper around SourceAnnotationExtractor::Annotation.register_extensions in railties' configuration like:

config.annotations.register_extensions("coffee") do
  /regex/
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep scss and sass

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this will be sass-rails job.

@rafaelfranca
Copy link
Member

👍 for @robin850 idea.

@robertomiranda
Copy link
Contributor Author

@robin850 👍 for the wrapper. I'm going to review the tests

@robertomiranda
Copy link
Contributor Author

  • Tests Fixed
  • Changelog entry added
  • Config wrapper Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update it to:

Add public API to register new extensions for rake notes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add an example on how to register new stuff, and maybe a guides update if we have something about rake notes in there.

@robertomiranda
Copy link
Contributor Author

All done

guilleiguaran added a commit that referenced this pull request Mar 17, 2014
Add Public Api for Register New Extensions for Rake Notes
@guilleiguaran guilleiguaran merged commit 4a69c93 into rails:master Mar 17, 2014
@guilleiguaran
Copy link
Member

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants