New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1272 (retry 3) #1443

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@winterchord
Contributor

winterchord commented Jun 1, 2011

Set reverse_order_value when asked to reverse_order().
Do the actual reversal in build_arel.

And take in code review comments from @jonleighton:

  • Add tests to ensure expectations of how reverse_order should work
  • Tests are happy in mysql, mysql2, sqlite3, sqlite3_mem, postgresql (I don't have any other dbs available)
Fix issue #1272
Set reverse_order_value when asked to reverse_order().
Do the actual reversal in build_arel.
@jonleighton

This comment has been minimized.

Member

jonleighton commented Jun 1, 2011

Great, thanks. I have merged.

I had to amend the commit to remove trailing white space. You can probably install a plugin or something for your editor which will automatically remove trailing white space, this keeps the diffs clean.

@jonleighton jonleighton closed this Jun 1, 2011

@winterchord

This comment has been minimized.

Contributor

winterchord commented Jun 1, 2011

Ah, okay. Thanks for the tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment