Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Only for 3-0-stable #1453

Closed
wants to merge 1 commit into from

2 participants

@arunagw
Collaborator

Please do not merge master. Fix broken 3-0-stable.

@arunagw
Collaborator

Discussion reference here

230f788#commitcomment-410835

@sikachu
Collaborator

Hi,

I think the best way to resolve that to revert this commit instead [4c0bed0]

Thank you for sending in, I'm really appreciate it. I tried to test it with JRuby too, and totally unable to try it. If you're working on fixing the tests for JRuby that's going to be awesome.

@sikachu sikachu closed this
@arunagw
Collaborator

@sikachu yeah revert only in 3-0-stable :-)

Yeah i am fixing for jruby. It will be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 activerecord/test/cases/attribute_methods_test.rb
View
4 activerecord/test/cases/attribute_methods_test.rb
@@ -126,9 +126,9 @@ def test_read_attributes_before_type_cast_on_boolean
bool = Boolean.create({ "value" => false })
if RUBY_PLATFORM =~ /java/
# JRuby will return the value before typecast as string
- assert_equal "0", bool.reload.attributes_before_type_cast["value"]
- else
assert_equal 0, bool.reload.attributes_before_type_cast["value"]
+ else
+ assert_equal "0", bool.reload.attributes_before_type_cast["value"]
end
end
end
Something went wrong with that request. Please try again.