Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrapping div with inline styles for hidden form fields. #14738

Merged
merged 1 commit into from Apr 17, 2014
Merged

Remove wrapping div with inline styles for hidden form fields. #14738

merged 1 commit into from Apr 17, 2014

Conversation

tilsammans
Copy link
Contributor

@tilsammans tilsammans commented Apr 13, 2014

We are dropping HTML 4.01 and XHTML strict compliance since input tags directly inside a form are valid HTML5, and the absense of inline styles help in validating for Content Security Policy.

work around Firefox 12 not submitting invisible inputs. With HTML5 as the default doctype
and Firefox 12 market share at 0.21% the time has come for these to go.

Fixes #11407.
Copy link
Member

@jeremy jeremy Apr 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omit.

We are dropping HTML 4.01 and XHTML strict compliance since input
tags directly inside a form are valid HTML5, and the absense of
inline styles help in validating for Content Security Policy.
@tilsammans
Copy link
Contributor Author

tilsammans commented Apr 14, 2014

Pushed.

@tilsammans
Copy link
Contributor Author

tilsammans commented Apr 17, 2014

@jeremy @rafaelfranca I made the changes you suggested. This is good to go?

@jeremy
Copy link
Member

jeremy commented Apr 17, 2014

Looks good. Needs a rebase against latest master, then good to merge.

@rafaelfranca
Copy link
Member

rafaelfranca commented Apr 17, 2014

I already merged manually. Thanks you @tilsammans

@rafaelfranca rafaelfranca merged commit 89ff1f8 into rails:master Apr 17, 2014
rafaelfranca added a commit that referenced this pull request Apr 17, 2014
Remove wrapping div with inline styles for hidden form fields.

Conflicts:
	actionview/CHANGELOG.md
@tilsammans tilsammans deleted the pull/11407 branch Apr 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants