Remove wrapping div with inline styles for hidden form fields. #14738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| work around Firefox 12 not submitting invisible inputs. With HTML5 as the default doctype | ||
| and Firefox 12 market share at 0.21% the time has come for these to go. | ||
|
|
||
| Fixes #11407. |
We are dropping HTML 4.01 and XHTML strict compliance since input tags directly inside a form are valid HTML5, and the absense of inline styles help in validating for Content Security Policy.
|
Pushed. |
|
@jeremy @rafaelfranca I made the changes you suggested. This is good to go? |
|
Looks good. Needs a rebase against latest master, then good to merge. |
|
I already merged manually. Thanks you @tilsammans |
rafaelfranca
added a commit
that referenced
this pull request
Apr 17, 2014
Remove wrapping div with inline styles for hidden form fields. Conflicts: actionview/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are dropping HTML 4.01 and XHTML strict compliance since input tags directly inside a form are valid HTML5, and the absense of inline styles help in validating for Content Security Policy.