Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix behavior of select! to be consistent with select #14752 #14757
Select mimics the block interface of arrays, but does not mock the
Thanks to @eric-smartlove for pointing out the issue.
referenced this pull request
Apr 15, 2014
That seems great. I actually didn't know we had that blacklist of methods.
I'll put in a PR tonight.
On Tue, Apr 15, 2014 at 10:25 AM, Rafael Mendonça França <
The easy way to fix it is just checking if the method is
Btw, it is not the ideal implementation (we could rename all these internals mutator methods to use underscore), but that's another story. EDIT: It would be good to try it.
@estsauver looks good. Nice job
I think we should also update the commit message, wdyt?
Maybe just saying that
Good call, I'll update the commit message.