Fix for #1482 #1483

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@radar
Contributor

radar commented Jun 4, 2011

It turns out that I do know enough about the Rails process to fix this. Who would have thought?

@radar

This comment has been minimized.

Show comment Hide comment
@radar

radar Jun 4, 2011

Contributor

Oops, this fixes the controller generator but breaks the model generator in ways that I haven't yet been able to figure out. Tomorrow I will be spending the whole day driving to Brisbane so I won't be able to figure it out then.

Contributor

radar commented Jun 4, 2011

Oops, this fixes the controller generator but breaks the model generator in ways that I haven't yet been able to figure out. Tomorrow I will be spending the whole day driving to Brisbane so I won't be able to figure it out then.

@radar

This comment has been minimized.

Show comment Hide comment
@radar

radar Jun 7, 2011

Contributor

@josevalim: These changes add two tests for generators within an engine that are both failing, conclusively proving that it's broken within master at the moment. I have no idea myself how to fix these so any assistance I can get from either you or @drogus at understanding the generators code here would be greatly appreciated.

Per your advice, you can revert 62b207f if you wish which re-adds the engines hack that I didn't know was a hack.

Contributor

radar commented Jun 7, 2011

@josevalim: These changes add two tests for generators within an engine that are both failing, conclusively proving that it's broken within master at the moment. I have no idea myself how to fix these so any assistance I can get from either you or @drogus at understanding the generators code here would be greatly appreciated.

Per your advice, you can revert 62b207f if you wish which re-adds the engines hack that I didn't know was a hack.

@parndt

This comment has been minimized.

Show comment Hide comment
@parndt

parndt Jun 7, 2011

Contributor

+1 - I believe this is a blocking issue to releasing 3.1 as with this sort of functionality I believe it is incredibly important to trust that it works precisely as expected.

Contributor

parndt commented Jun 7, 2011

+1 - I believe this is a blocking issue to releasing 3.1 as with this sort of functionality I believe it is incredibly important to trust that it works precisely as expected.

@drogus

This comment has been minimized.

Show comment Hide comment
@drogus

drogus Jun 7, 2011

Member

Closing as this is something that should go for #1356, I'll link it there.

Member

drogus commented Jun 7, 2011

Closing as this is something that should go for #1356, I'll link it there.

@drogus drogus closed this Jun 7, 2011

jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011

Add ActiveSupport::Multibyte::Chars#ord method so that it returns cor…
…rect Unicode value instead of falling back on String#ord in CoreExtensions, which is not multibyte compatible

[#1483 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment