Fixed an issue with migrating legacy json cookies. #14850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,9 @@ | |||
| * Fixed an issue with migrating legacy json cookies. | |||
|
|
|||
There was a problem hiding this comment.
Would be nice to include, actual error here.
Previously, the `VerifyAndUpgradeLegacySignedMessage` assumes all incoming cookies are marshal-encoded. This is not the case when `secret_token` is used in conjunction with the `:json` or `:hybrid` serializer. In those case, when upgrading to use `secret_key_base`, this would cause a `TypeError: incompatible marshal file format` and a 500 error for the user. Fixes rails#14774. *Godfrey Chan*
|
These tests could really use some refactoring later 馃槩 |
|
|
guilleiguaran
added a commit
that referenced
this pull request
Apr 23, 2014
Fixed an issue with migrating legacy json cookies.
guilleiguaran
added a commit
that referenced
this pull request
May 23, 2014
Fixed an issue with migrating legacy json cookies. Conflicts: actionpack/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
VerifyAndUpgradeLegacySignedMessageassumes all incomingcookies are marshal-encoded. This is not the case when
secret_tokenisused in conjunction with the
:jsonor:hybridserializer.In those case, when upgrading to use
secret_key_base, this would cause aTypeError: incompatible marshal file formatand a 500 error for the user.Fixes #14774.
Godfrey Chan
cc @rafaelfranca @guilleiguaran
馃槩 馃敨