Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Simplify _prefixes #15026
This simplifies the logic to compile the
It is now implemented with a proper recursion travelling up the inheritance chain instead of doing all the work locally in the concrete controller. Controllers in the chain can now define their local
We use this extensively in Cells for the new Trailblazer file layout. I thought it might be helpful to push that back to the core.
Totally agree about the proper documentation and testing and I will add that once you give me the OK
Overriding on the instance level is still possible by overriding
I don't know what's the deal with those underscored methods, we can remove them, I don't see what they stand for.
Thanks for your prompt relpy, @josevalim!
The problem is that those methods should be public but might interfere with actual controller actions. If
I personally find it OK to leave them underscored, just to avoid the hassle with name clashes.
Other than that my only concern is that I ruthlessly removed