Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecation warning #15100

Conversation

@eileencodes
Copy link
Member

@eileencodes eileencodes commented May 13, 2014

This deprecation was released in 4.1.0 and can be removed for 4.2.0,
deprecation message / handling is no longer necessary.

@chancancode
Copy link
Member

@chancancode chancancode commented May 13, 2014

Looks like you included an extra test file by accident!

@eileencodes
Copy link
Member Author

@eileencodes eileencodes commented May 13, 2014

Ah omg you're right that was from my rebase (where is a facepalm emoji when you need it?!) 😲

This deprecation was released in 4.1.0 and can be removed for 4.2.0,
deprecation message / handling is no longer necessary.
@eileencodes
Copy link
Member Author

@eileencodes eileencodes commented May 13, 2014

@chancancode ok I fixed it, sorry about that.😊

@chancancode
Copy link
Member

@chancancode chancancode commented May 13, 2014

👍 Did we not have any tests for this behaviour (that we should remove with this)? On a casual scan I couldn't seem to find any, but that seems odd. Guess travis will find out for me!

@eileencodes
Copy link
Member Author

@eileencodes eileencodes commented May 13, 2014

Yea the tests in both ActiveSupport and ActionPack passed. I even went back in the commit history and didn't see any tests that were added around this time so I'm not sure. 😄

chancancode added a commit that referenced this pull request May 14, 2014
…-no-longer-needed

remove deprecation warning
@chancancode chancancode merged commit 522110a into rails:master May 14, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@chancancode
Copy link
Member

@chancancode chancancode commented May 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.