remove deprecation warning #15100

Merged
merged 1 commit into from May 14, 2014

Conversation

Projects
None yet
2 participants
@eileencodes
Member

eileencodes commented May 13, 2014

This deprecation was released in 4.1.0 and can be removed for 4.2.0,
deprecation message / handling is no longer necessary.

@chancancode

This comment has been minimized.

Show comment
Hide comment
@chancancode

chancancode May 13, 2014

Member

Looks like you included an extra test file by accident!

Member

chancancode commented May 13, 2014

Looks like you included an extra test file by accident!

@eileencodes

This comment has been minimized.

Show comment
Hide comment
@eileencodes

eileencodes May 13, 2014

Member

Ah omg you're right that was from my rebase (where is a facepalm emoji when you need it?!) 😲

Member

eileencodes commented May 13, 2014

Ah omg you're right that was from my rebase (where is a facepalm emoji when you need it?!) 😲

remove deprecation warning
This deprecation was released in 4.1.0 and can be removed for 4.2.0,
deprecation message / handling is no longer necessary.
@eileencodes

This comment has been minimized.

Show comment
Hide comment
@eileencodes

eileencodes May 13, 2014

Member

@chancancode ok I fixed it, sorry about that.😊

Member

eileencodes commented May 13, 2014

@chancancode ok I fixed it, sorry about that.😊

@chancancode

This comment has been minimized.

Show comment
Hide comment
@chancancode

chancancode May 13, 2014

Member

👍 Did we not have any tests for this behaviour (that we should remove with this)? On a casual scan I couldn't seem to find any, but that seems odd. Guess travis will find out for me!

Member

chancancode commented May 13, 2014

👍 Did we not have any tests for this behaviour (that we should remove with this)? On a casual scan I couldn't seem to find any, but that seems odd. Guess travis will find out for me!

@eileencodes

This comment has been minimized.

Show comment
Hide comment
@eileencodes

eileencodes May 13, 2014

Member

Yea the tests in both ActiveSupport and ActionPack passed. I even went back in the commit history and didn't see any tests that were added around this time so I'm not sure. 😄

Member

eileencodes commented May 13, 2014

Yea the tests in both ActiveSupport and ActionPack passed. I even went back in the commit history and didn't see any tests that were added around this time so I'm not sure. 😄

chancancode added a commit that referenced this pull request May 14, 2014

Merge pull request #15100 from eileencodes/remove-deprecation-warning…
…-no-longer-needed

remove deprecation warning

@chancancode chancancode merged commit 522110a into rails:master May 14, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@chancancode

This comment has been minimized.

Show comment
Hide comment
Member

chancancode commented May 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment