Add RFC 4791 MKCALENDAR method #15121

Merged
merged 1 commit into from May 15, 2014

Conversation

Projects
None yet
3 participants
@skarpiesz
Contributor

skarpiesz commented May 15, 2014

Without it I get

ERROR ActionController::UnknownHttpMethod: MKCALENDAR, accepted HTTP methods are OPTIONS, GET, HEAD, POST, PUT, DELETE, TRACE, CONNECT, PROPFIND, PROPPATCH, MKCOL, COPY, MOVE, LOCK, UNLOCK, VERSION-CONTROL, REPORT, CHECKOUT, CHECKIN, UNCHECKOUT, MKWORKSPACE, UPDATE, LABEL, MERGE, BASELINE-CONTROL, MKACTIVITY, ORDERPATCH, ACL, SEARCH, and PATCH
@arthurnn

This comment has been minimized.

Show comment
Hide comment
@arthurnn

arthurnn May 15, 2014

Member

Is there any way to add tests for this?

Member

arthurnn commented May 15, 2014

Is there any way to add tests for this?

match '/' => s.simple_app(method), :via => method.underscore.to_sym
end
end
end
- (RFC2616 + RFC2518 + RFC3253 + RFC3648 + RFC3744 + RFC5323 + RFC5789).each do |method|
+ (RFC2616 + RFC2518 + RFC3253 + RFC3648 + RFC3744 + RFC5323 + RFC4791 + RFC5789).each do |method|
test "request method #{method.underscore} can be matched" do
get '/', nil, 'REQUEST_METHOD' => method
assert_equal method, @response.body

This comment has been minimized.

@skarpiesz

skarpiesz May 15, 2014

Contributor

@arthurnn It's here

@skarpiesz

skarpiesz May 15, 2014

Contributor

@arthurnn It's here

This comment has been minimized.

@arthurnn

arthurnn May 15, 2014

Member

ops 😓 ...

@arthurnn

arthurnn May 15, 2014

Member

ops 😓 ...

@rafaelfranca rafaelfranca merged commit 42728c7 into rails:master May 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request May 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment