Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RFC 4791 MKCALENDAR method #15121

Merged
merged 1 commit into from
May 15, 2014
Merged

Add RFC 4791 MKCALENDAR method #15121

merged 1 commit into from
May 15, 2014

Conversation

skarpesh
Copy link

Without it I get

ERROR ActionController::UnknownHttpMethod: MKCALENDAR, accepted HTTP methods are OPTIONS, GET, HEAD, POST, PUT, DELETE, TRACE, CONNECT, PROPFIND, PROPPATCH, MKCOL, COPY, MOVE, LOCK, UNLOCK, VERSION-CONTROL, REPORT, CHECKOUT, CHECKIN, UNCHECKOUT, MKWORKSPACE, UPDATE, LABEL, MERGE, BASELINE-CONTROL, MKACTIVITY, ORDERPATCH, ACL, SEARCH, and PATCH

@arthurnn
Copy link
Member

Is there any way to add tests for this?

skarpesh
skarpesh reviewed May 15, 2014
View reviewed changes
actionpack/test/dispatch/routing_test.rb
match '/' => s.simple_app(method), :via => method.underscore.to_sym
end
end
end

(RFC2616 + RFC2518 + RFC3253 + RFC3648 + RFC3744 + RFC5323 + RFC5789).each do |method|
(RFC2616 + RFC2518 + RFC3253 + RFC3648 + RFC3744 + RFC5323 + RFC4791 + RFC5789).each do |method|
test "request method #{method.underscore} can be matched" do
get '/', nil, 'REQUEST_METHOD' => method
assert_equal method, @response.body
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arthurnn It's here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops 😓 ...

@rafaelfranca rafaelfranca merged commit 42728c7 into rails:master May 15, 2014
rafaelfranca added a commit that referenced this pull request May 15, 2014
@rafaelfranca
Merge pull request #15121 from skarpesh/rfc4791-methods
cf50bbd 
Add RFC 4791 MKCALENDAR method
@dideler dideler mentioned this pull request Jan 13, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skarpesh @arthurnn @rafaelfranca