Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC 4791 MKCALENDAR method #15121

Merged
merged 1 commit into from May 15, 2014
Merged

Conversation

@skarpesh
Copy link
Contributor

skarpesh commented May 15, 2014

Without it I get

ERROR ActionController::UnknownHttpMethod: MKCALENDAR, accepted HTTP methods are OPTIONS, GET, HEAD, POST, PUT, DELETE, TRACE, CONNECT, PROPFIND, PROPPATCH, MKCOL, COPY, MOVE, LOCK, UNLOCK, VERSION-CONTROL, REPORT, CHECKOUT, CHECKIN, UNCHECKOUT, MKWORKSPACE, UPDATE, LABEL, MERGE, BASELINE-CONTROL, MKACTIVITY, ORDERPATCH, ACL, SEARCH, and PATCH
kasper
@arthurnn
Copy link
Member

arthurnn commented May 15, 2014

Is there any way to add tests for this?

match '/' => s.simple_app(method), :via => method.underscore.to_sym
end
end
end

(RFC2616 + RFC2518 + RFC3253 + RFC3648 + RFC3744 + RFC5323 + RFC5789).each do |method|
(RFC2616 + RFC2518 + RFC3253 + RFC3648 + RFC3744 + RFC5323 + RFC4791 + RFC5789).each do |method|
test "request method #{method.underscore} can be matched" do
get '/', nil, 'REQUEST_METHOD' => method
assert_equal method, @response.body

This comment has been minimized.

Copy link
@skarpesh

skarpesh May 15, 2014

Author Contributor

@arthurnn It's here

This comment has been minimized.

Copy link
@arthurnn

arthurnn May 15, 2014

Member

ops 😓 ...

@rafaelfranca rafaelfranca merged commit 42728c7 into rails:master May 15, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
rafaelfranca added a commit that referenced this pull request May 15, 2014
Add RFC 4791 MKCALENDAR method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.