Fixed for SafeBuffer #1541

Merged
merged 2 commits into from Jun 8, 2011

Conversation

Projects
None yet
4 participants
@arunagw
Member

arunagw commented Jun 8, 2011

Fixed for SafeBuffer. Was throwing errors. Cannot modify SafeBuffer in place

Caching test are still failing don't know why response.body coming like this.

  1) Failure:
test_fragment_caching(FunctionalFragmentCachingTest)
    [/Users/arun/checkouts/rails/actionpack/test/controller/caching_test.rb:741:in `test_fragment_caching'
     /Users/arun/checkouts/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `__send__'
     /Users/arun/checkouts/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `run'
     /Users/arun/checkouts/rails/activesupport/lib/active_support/callbacks.rb:434:in `_run_setup_callbacks'
     /Users/arun/checkouts/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:65:in `run']:
<"Hello\nThis bit's fragment cached\n"> expected but was
<"Hello\nThis bit's fragment cachedThis bit's fragment cached\n">.

  2) Failure:
test_html_formatted_fragment_caching(FunctionalFragmentCachingTest)
    [/Users/arun/checkouts/rails/actionpack/test/controller/caching_test.rb:773:in `test_html_formatted_fragment_caching'
     /Users/arun/checkouts/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `__send__'
     /Users/arun/checkouts/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `run'
     /Users/arun/checkouts/rails/activesupport/lib/active_support/callbacks.rb:434:in `_run_setup_callbacks'
     /Users/arun/checkouts/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:65:in `run']:
<"\n

ERB

\n\n"> expected but was <"\n

ERB

ERB

\n\n">.
@cmeiklejohn

This comment has been minimized.

Show comment
Hide comment
@cmeiklejohn

cmeiklejohn Jun 8, 2011

Contributor

I've fixed this here: #1539

You need to slice out the content that's going into the fragment for the tests to pass.

Contributor

cmeiklejohn commented Jun 8, 2011

I've fixed this here: #1539

You need to slice out the content that's going into the fragment for the tests to pass.

@arunagw

This comment has been minimized.

Show comment
Hide comment
@arunagw

arunagw Jun 8, 2011

Member

@cmeiklejohn you bet!

Member

arunagw commented Jun 8, 2011

@cmeiklejohn you bet!

tenderlove added a commit that referenced this pull request Jun 8, 2011

@tenderlove tenderlove merged commit bdc80dd into rails:3-0-stable Jun 8, 2011

@filipegiusti

This comment has been minimized.

Show comment
Hide comment
@filipegiusti

filipegiusti Jun 8, 2011

Have you did a pull request? This is blocking me to use rails 3.0.8.
:(

Have you did a pull request? This is blocking me to use rails 3.0.8.
:(

This comment has been minimized.

Show comment
Hide comment
@arunagw

arunagw Jun 8, 2011

Owner

Yeah it's in 3-0-stable branch. Need to wait a next rc. You can use directly 3-0-stable if you want to.

/cc @josevalim

Owner

arunagw replied Jun 8, 2011

Yeah it's in 3-0-stable branch. Need to wait a next rc. You can use directly 3-0-stable if you want to.

/cc @josevalim

@filipegiusti

This comment has been minimized.

Show comment
Hide comment
@filipegiusti

filipegiusti Jun 8, 2011

Ow, I haven't noticed. That's cool.
I will wait for 3.0.9

Ow, I haven't noticed. That's cool.
I will wait for 3.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment