rm cached attributes#15429
Conversation
There was a problem hiding this comment.
We need to deprecate this one too.
|
@jeremy WDYT? |
|
Note: This does not change behavior for anyone who has not called |
|
@jeremy Ping! |
|
@rafaelfranca @jeremy Any more feedback on this? Need this for what I'm working on. |
|
@rafaelfranca @jeremy Ping! |
|
For me it is |
but maybe
|
Thank you! 😄 |
There was a problem hiding this comment.
"Calling cache_attributes is no longer necessary. All attributes are cached."
The last sentence talking about downsides makes sense to Rails implementors, not app developers.
|
Updated. |
|
👍 |
The original patch that added this concept can be found [here](https://web.archive.org/web/20090601022739/http://dev.rubyonrails.org/ticket/9767). The current default behavior is to cache everything except serialized columns, unless the user specified otherwise. If anyone were to specify otherwise, many types would actually be completely broken. Still, the method is left in place with a deprecation warning in case anyone is actually still calling this method.
|
Sorry, I know this is old, but I am confused by this change. Why was it necessary? The comments indicate that many types would be broken, but which ones, and how? Why should string-valued attributes be cached? |
Remove cached attributes from Configuring guide [ci skip] This was removed in #15429
4 participants
The original patch that added this concept can be found here. The current default behavior is to cache everything except serialized columns, unless the user specified otherwise. If anyone were to specify otherwise, many types would actually be completely broken. Still, the method is left in place with a deprecation warning in case anyone is actually still calling this method.