Remove deprecated method ActiveRecord::Migrator.proper_table_name #15512

Merged
merged 1 commit into from Jun 5, 2014

Conversation

Projects
None yet
3 participants
@akshay-vishnoi
Contributor

akshay-vishnoi commented Jun 4, 2014

No description provided.

@senny

This comment has been minimized.

Show comment
Hide comment
@senny

senny Jun 5, 2014

Member

@akshay-vishnoi this needs a changelog entry.

Member

senny commented Jun 5, 2014

@akshay-vishnoi this needs a changelog entry.

@akshay-vishnoi

This comment has been minimized.

Show comment
Hide comment
@akshay-vishnoi

akshay-vishnoi Jun 5, 2014

Contributor

Hi @senny. I have updated changelog, please check. 😄

Contributor

akshay-vishnoi commented Jun 5, 2014

Hi @senny. I have updated changelog, please check. 😄

@senny

This comment has been minimized.

Show comment
Hide comment
@senny

senny Jun 5, 2014

Member

@akshay-vishnoi merged and modified the changelog entry slightly. Thanks 💛

Member

senny commented Jun 5, 2014

@akshay-vishnoi merged and modified the changelog entry slightly. Thanks 💛

@senny senny merged commit 6da0072 into rails:master Jun 5, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

senny added a commit that referenced this pull request Jun 5, 2014

Merge pull request #15512 from akshay-vishnoi/delete-deprecated-method
Remove deprecated method ActiveRecord::Migrator.proper_table_name
@akshay-vishnoi

This comment has been minimized.

Show comment
Hide comment
@akshay-vishnoi

akshay-vishnoi Jun 5, 2014

Contributor

Yeah, you did better actually. Thanks 💚

Contributor

akshay-vishnoi commented Jun 5, 2014

Yeah, you did better actually. Thanks 💚

@scarver2

This comment has been minimized.

Show comment
Hide comment
@scarver2

scarver2 Oct 29, 2014

How does one go about resolving this deprecation? I've posted the question on SO with example source code.
http://stackoverflow.com/questions/26622488/activerecordmigrator-proper-table-name-is-deprecated

How does one go about resolving this deprecation? I've posted the question on SO with example source code.
http://stackoverflow.com/questions/26622488/activerecordmigrator-proper-table-name-is-deprecated

@senny

This comment has been minimized.

Show comment
Hide comment
@senny

senny Oct 29, 2014

Member

@scarver2 my guess is that this is caused by a gem. Do you use something, which hooks into migrations? If not, can you upload a minimal sample application that reproduces the issue? You can also post an executable test-case that showcases the deprecation. Use this script as a starting point.

Member

senny commented Oct 29, 2014

@scarver2 my guess is that this is caused by a gem. Do you use something, which hooks into migrations? If not, can you upload a minimal sample application that reproduces the issue? You can also post an executable test-case that showcases the deprecation. Use this script as a starting point.

@smoyth smoyth referenced this pull request in jenseng/hair_trigger Nov 6, 2015

Closed

NameError: undefined method `proper_table_name' for class `Class' #49

yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request May 20, 2016

@yahonda yahonda referenced this pull request in rsim/oracle-enhanced May 20, 2016

Merged

Use ActiveRecord initialize_schema_migrations_table #843

@ngtk ngtk referenced this pull request in Fivell/pg_power Dec 20, 2016

Merged

ActiveRecord::Migrator.proper_table_name has been removed #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment