Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated method ActiveRecord::Migrator.proper_table_name #15512

Merged
merged 1 commit into from Jun 5, 2014

Conversation

@akshay-vishnoi
Copy link
Contributor

akshay-vishnoi commented Jun 4, 2014

No description provided.

@senny
Copy link
Member

senny commented Jun 5, 2014

@akshay-vishnoi this needs a changelog entry.

@akshay-vishnoi
Copy link
Contributor Author

akshay-vishnoi commented Jun 5, 2014

Hi @senny. I have updated changelog, please check. 😄

@senny
Copy link
Member

senny commented Jun 5, 2014

@akshay-vishnoi merged and modified the changelog entry slightly. Thanks 💛

@senny senny merged commit 6da0072 into rails:master Jun 5, 2014
1 check was pending
1 check was pending
continuous-integration/travis-ci The Travis CI build is in progress
Details
senny added a commit that referenced this pull request Jun 5, 2014
Remove deprecated method ActiveRecord::Migrator.proper_table_name
@akshay-vishnoi
Copy link
Contributor Author

akshay-vishnoi commented Jun 5, 2014

Yeah, you did better actually. Thanks 💚

@scarver2
Copy link

scarver2 commented Oct 29, 2014

How does one go about resolving this deprecation? I've posted the question on SO with example source code.
http://stackoverflow.com/questions/26622488/activerecordmigrator-proper-table-name-is-deprecated

@senny
Copy link
Member

senny commented Oct 29, 2014

@scarver2 my guess is that this is caused by a gem. Do you use something, which hooks into migrations? If not, can you upload a minimal sample application that reproduces the issue? You can also post an executable test-case that showcases the deprecation. Use this script as a starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.