SecurePassword - Validate password must be less than or equal to 72 #15708

Merged
merged 1 commit into from Jun 14, 2014

Conversation

Projects
None yet
2 participants
@akshay-vishnoi
Contributor

akshay-vishnoi commented Jun 14, 2014

See #14591, Reason - BCrypt hash function can handle maximum 72 characters.

@akshay-vishnoi

This comment has been minimized.

Show comment
Hide comment
Contributor

akshay-vishnoi commented Jun 14, 2014

cc: @matthewd

@@ -2,6 +2,8 @@ module ActiveModel
module SecurePassword
extend ActiveSupport::Concern
+ MAX_PASSWORD_LENGTH_ALLOWED = 72

This comment has been minimized.

@chancancode

chancancode Jun 14, 2014

Member

Can you put a comment above this constant explaining why it is necessary?

@chancancode

chancancode Jun 14, 2014

Member

Can you put a comment above this constant explaining why it is necessary?

Akshay Vishnoi
SecurePassword - Validate password must be less than or equal to 72
See #14591, Reason - BCrypt hash function can handle maximum 72 characters.
@akshay-vishnoi

This comment has been minimized.

Show comment
Hide comment
@akshay-vishnoi

akshay-vishnoi Jun 14, 2014

Contributor

Please check the updated code.

Contributor

akshay-vishnoi commented Jun 14, 2014

Please check the updated code.

chancancode added a commit that referenced this pull request Jun 14, 2014

Merge pull request #15708 from akshay-vishnoi/secure_password
SecurePassword - Validate password must be less than or equal to 72

@chancancode chancancode merged commit 6fa7726 into rails:master Jun 14, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
@akshay-vishnoi

This comment has been minimized.

Show comment
Hide comment
@akshay-vishnoi

akshay-vishnoi Jun 14, 2014

Contributor

Hey I forgot, does this need CHANGELOG entry?

Contributor

akshay-vishnoi commented Jun 14, 2014

Hey I forgot, does this need CHANGELOG entry?

chancancode added a commit that referenced this pull request Jun 14, 2014

@chancancode

This comment has been minimized.

Show comment
Hide comment
@chancancode

chancancode Jun 14, 2014

Member

No worries, I fixed it for you 😄

Member

chancancode commented Jun 14, 2014

No worries, I fixed it for you 😄

@akshay-vishnoi

This comment has been minimized.

Show comment
Hide comment
@akshay-vishnoi

akshay-vishnoi Jun 14, 2014

Contributor

Thanks 💚 😄

Contributor

akshay-vishnoi commented Jun 14, 2014

Thanks 💚 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment