Make cookie key environment dependent

[ryana]

More than once I've been bitten by cookie issues when testing between staging and production environment. This change will prevent a lot of hair-pulling on new applications.

[rafaelfranca]

Yes. I had this problem too. I just not sure if would not better to set this configuration in the environment files instead of a initializer now.

@jeremy @matthewd WDYT?

[eileencodes]

@ryana looks like you have some test failures related to this change.

  1) Failure:
AppGeneratorTest#test_application_name_is_detected_if_it_exists_and_app_folder_renamed [test/generators/app_generator_test.rb:125]:
Expected /_myapp_session/ to match "# Be sure to restart your server when you modify this file.\n\nRails.application.config.session_store :cookie_store, key: \"_myapp_\#{Rails.env}_session\"\n".

[ryana]

@rafaelfranca I had that thought too, but didn't want to rock the boat too much ;)

@eileencodes whoops sorry. I'll push a fix this afternoon!

[repinel]

@rafaelfranca Any thoughts if this should be moved to the environments files? It seems more reasonable then having the key generated on the fly based on the environment.

[rafaelfranca]

I think this is fine as is right now. @ryana do you still have interest on fixing the tests and rebasing the branch?

[rails-bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.