Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rails:update to the upgrading guides #15810

Merged
merged 1 commit into from Jun 24, 2014

Conversation

@maurogeorge
Copy link
Contributor

maurogeorge commented Jun 19, 2014

No description provided.

@zzak
zzak reviewed Jun 19, 2014
View changes
guides/source/upgrading_ruby_on_rails.md Outdated
...
```

Do not forget to check your changes, to see if there were any unexpected change.

This comment has been minimized.

Copy link
@zzak

zzak Jun 19, 2014

Member

Don't forget to review the difference, to see if there were any unexpected changes.

@maurogeorge

This comment has been minimized.

Copy link
Contributor Author

maurogeorge commented Jun 19, 2014

@zzak 👍 for the review. Fixed

@vijaydev
vijaydev reviewed Jun 19, 2014
View changes
guides/source/upgrading_ruby_on_rails.md Outdated
@@ -22,6 +22,27 @@ Rails generally stays close to the latest released Ruby version when it's releas

TIP: Ruby 1.8.7 p248 and p249 have marshaling bugs that crash Rails. Ruby Enterprise Edition has these fixed since the release of 1.8.7-2010.02. On the 1.9 front, Ruby 1.9.1 is not usable because it outright segfaults, so if you want to use 1.9.x, jump straight to 1.9.3 for smooth sailing.

### The Rake Task

Rails provides the `rails:update` rake task. So after update rails to the desired version run this rake task.

This comment has been minimized.

Copy link
@vijaydev

vijaydev Jun 19, 2014

Member

"So after update rails to the desired version run this rake task." - this isn't clear. Do you mean to say "After updating the Rails version in the Gemfile, run this rake task" ?

@vijaydev
vijaydev reviewed Jun 19, 2014
View changes
guides/source/upgrading_ruby_on_rails.md Outdated
### The Rake Task

Rails provides the `rails:update` rake task. So after update rails to the desired version run this rake task.
This will help you with the creation of new files and changes of old files in a interactive section.

This comment has been minimized.

Copy link
@vijaydev

vijaydev Jun 19, 2014

Member

s/section/session.

This comment has been minimized.

Copy link
@maurogeorge

maurogeorge Jun 19, 2014

Author Contributor

@vijaydev thanks for the review.

@zzak
zzak reviewed Jun 19, 2014
View changes
guides/source/upgrading_ruby_on_rails.md Outdated
### The Rake Task

Rails provides the `rails:update` rake task. After updating the Rails version in the Gemfile, run this rake task.
This will help you with the creation of new files and changes of old files in a interactive session.

This comment has been minimized.

Copy link
@zzak

zzak Jun 19, 2014

Member

Could you wrap this at 80 chars?

@matthewd

This comment has been minimized.

Copy link
Member

matthewd commented Jun 20, 2014

rails:update does have one big caveat: it interactively helps you move towards what a freshly-generated app would look like under the new version.

This means you can end up with "intended for new apps only" config options enabled, instead of their backwards-compatible defaults. For a recent example, see cookies_serializer.

Ideally, we would address this somehow, so it worked towards a slightly different target. But until then, it probably deserves some sort of warning.

@chancancode

This comment has been minimized.

Copy link
Member

chancancode commented Jun 20, 2014

@matthewd I think Rafael already fixed that on 4-1-stable, so I guess we started enforcing that contract? (ie this rake task should be reasonably safe to run on existing apps?)

@rafaelfranca

This comment has been minimized.

Copy link
Member

rafaelfranca commented Jun 20, 2014

Yes, I just fixed this on 4.1.2. The idea is to generate a configuration
safe enough to an application upgrading. The cookie_serializer file
generated on 4.1.1- were being using an unsafe content by mistake
On Jun 20, 2014 12:34 AM, "Godfrey Chan" notifications@github.com wrote:

@matthewd https://github.com/matthewd I think Rafael already fixed that
on 4-1-stable, so I guess we started enforcing that contract? (ie this rake
task should be reasonably safe to run on existing apps?)


Reply to this email directly or view it on GitHub
#15810 (comment).

@senny

This comment has been minimized.

Copy link
Member

senny commented Jun 24, 2014

I think it makes sense to add this to the upgrading guide. People that know the task are using it, so it's better for us to make sure it works with cases like the cookie_serializer than not documenting it and keep it semi-working.

senny added a commit that referenced this pull request Jun 24, 2014
Add rails:update to the upgrading guides
@senny senny merged commit b0594a7 into rails:master Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.