Revert #15502, and add a deprecation warning instead.#15878
Merged
Conversation
This is public API, and `simple_form` depends on the `nil` return value. We need to go through a deprecation cycle to return a null object. If people want hash access, they can access the hash.
rafaelfranca
added a commit
that referenced
this pull request
Jun 23, 2014
Revert #15502, and add a deprecation warning instead.
Contributor
There was a problem hiding this comment.
could .to_s be normalized inside the type_for_attribute method?
Contributor
Author
There was a problem hiding this comment.
We've been pushing to consistently use strings internally, rather than allowing both everywhere.
Member
|
Weird. Simple Form build should had fail on master 😢 |
Contributor
Author
|
I didn't actually confirm the report, but the fact that it came up at all made it clear someone somewhere is relying on this behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is public API, and
simple_formdepends on thenilreturn value.We need to go through a deprecation cycle to return a null object. If
people want hash access, they can access the hash.
Closes #15877