Add configuration to enable mail previews#15970
Merged
rafaelfranca merged 1 commit intoJul 1, 2014
Merged
Conversation
Member
|
@pixeltrix does the overall feature seems fine to you? |
Contributor
Author
|
I reworked this so there aren't any more changes inside |
Member
|
We need to update the configuration guides to add this new config. |
Contributor
Author
|
I've updated the configuration guides to include both this new config and the existing |
Member
|
Please squash your commits on a single one |
Adds `config.action_mailer.preview_enabled` This allows mail previewing to be enabled easily in non-development environments such as staging. The default is set to true for development so no changes should be required to existing Rails applications. The mail preview path can still be configured using the existing `config.action_mailer.preview_path` configuration option. Adding this avoids devs from having to do stuff like: https://gist.github.com/lengarvey/fa2c9bd6cdbeba96526a Update actionmailer/CHANGELOG with new configuration. Update configuring guide with new configuratation. Add `config.action_mailer.preview_path` to configuring guide.
rafaelfranca
added a commit
that referenced
this pull request
Jul 1, 2014
…_mail_preview Add configuration to enable mail previews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
config.action_mailer.preview_enabledThis allows mail previewing to be enabled easily in non-development
environments such as staging. The default is set to true for development
so no changes should be required to existing Rails applications.
The mail preview path can still be configured using the existing
config.action_mailer.preview_pathconfiguration option.Adding this prevents devs from having to do stuff like:
in order to enable mail previewing on staging.