-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration to enable mail previews #15970
Add configuration to enable mail previews #15970
Conversation
This config option can be used to enable the mail preview in environments | ||
other than development (such as staging). | ||
|
||
Defaults to `true` in staging and false elsewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/staging/development/?
@pixeltrix does the overall feature seems fine to you? |
I reworked this so there aren't any more changes inside |
We need to update the configuration guides to add this new config. |
I've updated the configuration guides to include both this new config and the existing |
Please squash your commits on a single one |
Adds `config.action_mailer.preview_enabled` This allows mail previewing to be enabled easily in non-development environments such as staging. The default is set to true for development so no changes should be required to existing Rails applications. The mail preview path can still be configured using the existing `config.action_mailer.preview_path` configuration option. Adding this avoids devs from having to do stuff like: https://gist.github.com/lengarvey/fa2c9bd6cdbeba96526a Update actionmailer/CHANGELOG with new configuration. Update configuring guide with new configuratation. Add `config.action_mailer.preview_path` to configuring guide.
…_mail_preview Add configuration to enable mail previews
Adds
config.action_mailer.preview_enabled
This allows mail previewing to be enabled easily in non-development
environments such as staging. The default is set to true for development
so no changes should be required to existing Rails applications.
The mail preview path can still be configured using the existing
config.action_mailer.preview_path
configuration option.Adding this prevents devs from having to do stuff like:
in order to enable mail previewing on staging.