Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] /javascript/ -> JavaScript - cover whole app #16042

Merged
merged 1 commit into from Jul 4, 2014

Conversation

akshay-vishnoi
Copy link
Contributor

No description provided.

@@ -207,7 +207,7 @@ $ bin/rails generate scaffold User name:string

Looking at this output, it's easy to understand how generators work in Rails 3.0 and above. The scaffold generator doesn't actually generate anything, it just invokes others to do the work. This allows us to add/replace/remove any of those invocations. For instance, the scaffold generator invokes the scaffold_controller generator, which invokes erb, test_unit and helper generators. Since each generator has a single responsibility, they are easy to reuse, avoiding code duplication.

Our first customization on the workflow will be to stop generating stylesheets, javascripts and test fixtures for scaffolds. We can achieve that by changing our configuration to the following:
Our first customization on the workflow will be to stop generating stylesheets, JavaScripts and test fixtures for scaffolds. We can achieve that by changing our configuration to the following:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"JavaScripts" sounds wrong to me. "javascripts" doesn't thrill me either, but it feels less bad somehow?

Perhaps we should just rephrase to something like "stylesheet, JavaScript and test fixture files"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better. Okay so I am updating this and change next to it.

@akshay-vishnoi
Copy link
Contributor Author

@matthewd - Updated, Please check. 😄

matthewd added a commit that referenced this pull request Jul 4, 2014
[ci skip] /javascript/ -> JavaScript - cover whole app
@matthewd matthewd merged commit bcd1b9c into rails:master Jul 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants