Add a required option to the model generator

[sgrif]

Syntax was chosen to follow the passing of multiple options to
decimal/numeric types. Curly braces, and allowing any of ,, ., or
- to be used as a separator to avoid the need for shell quoting. (I'm
intending to expand this to all columns, but that's another PR.

The required option will cause 3 things to change. required: true
will be added to the association. null: false will be added to the
column in the migration. add_foreign_key :table, :foreign_table will
be added if the association is not polymorphic.

Examples:

rails g model Account supplier:references{required}
rails g model Account "supplier:references{required,polymorphic}"
rails g model Account supplier:references{polymorphic-required}
rails g model Account supplier:references{polymorphic.required}

[sgrif]

/cc @dhh

[rafaelfranca]

We need to update the migration guides with this option.

[egilburg]

add_foreign_key :table, :foreign_table will be added if the association is not polymorphic.

This should be done for any references statement that's not polymorphic, not just required ones. Foreign keys may be null, only invalid non-nulls are restricted.

[sgrif]

@egilburg That's a conversation that's still being had, no decision has been made one way or the other yet.

[matthewd]

For the record, I'm with @egilburg: whether we generate FKs at all will presumably be a generator config option (regardless of its chosen default), but I believe that choice is unrelated to whether the value is required.

[sgrif]

I'm 👍 on FKs all the time as well. It sounds like that's the way most are leaning, I'll pull that out to a separate PR.

[dhh]

Looks good to me, but let's standardize on: rails g model Account supplier:references{required,polymorphic} -- don't like having 3 different splitters.

[sgrif]

@dhh That used to be the only splitter. The issue is using , as a splitter requires shell escaping.

[dhh]

Ah. Bummer. Okay, then let's use for only if that works.

On Jul 7, 2014, at 16:54, Sean Griffin notifications@github.com wrote:

@dhh That used to be the only splitter. The issue is using , as a splitter requires shell escaping.

—
Reply to this email directly or view it on GitHub.

[sgrif]

This has been updated.

[djbender]

@sgrif @rafaelfranca Did the migration docs get updated for this yet?