Address CVE-2014-4671 (JSONP Flash exploit) #16109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a comment before JSONP callbacks. See http://miki.it/blog/2014/7/8/abusing-jsonp-with-rosetta-flash/ for more details on the exploit in question.
Member
Member
|
(I believe this requires #16026 to work correctly in all cases, which is only in master afaik) |
Member
|
LGTM, I'll merge it. |
mehlah
added a commit
to mehlah/active_model_serializers
that referenced
this pull request
Mar 30, 2015
Since Rails 4.0.10, it prepends a JS comment to JSONP callbacks, to address CVE-2014-4671. Introduced in Rails at rails/rails#16109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a comment before JSONP callbacks. See
the reporter's blog post and the CVE for more information on the vulnerability.