Add support for Postgresql JSONB #16220
Conversation
|
👍 |
| @@ -1,3 +1,7 @@ | |||
| * Add support for Postgresql JSONB | |||
|
|
|||
| Philippe Creux, Chris Teague | |||
There was a problem hiding this comment.
*Philippe Creux*, *Chris Teague*
| @@ -29,6 +29,22 @@ def accessor | |||
| ActiveRecord::Store::StringKeyedHashAccessor | |||
| end | |||
| end | |||
|
|
|||
| class Jsonb < Json # :nodoc: | |||
There was a problem hiding this comment.
Can we put this in its own file?
|
One minor comment, looks fine otherwise. |
|
@sgrif I've just added |
| # the comparison here. Therefore, we need to parse and re-dump the | ||
| # raw value here to ensure the insignificant whitespaces are | ||
| # consitent with our encoder's output. | ||
| raw_old_value = type_cast_for_database(type_cast_from_database(raw_old_value)) |
There was a problem hiding this comment.
is this local variable change here recognized in super? does super share lexical scope with the subclass invoking it?
There was a problem hiding this comment.
Yes. Though IMO it's better to go with a more obviously-correct super(raw_old_value, new_value) in situations like this.
|
@pcreux looking good. Added a few comments then we should be good to go. |
| class PostgresqlJSONTest < ActiveRecord::TestCase | ||
| include PostgresqlJSONSharedTestCases | ||
|
|
||
| def column_type |
There was a problem hiding this comment.
@senny I prefer defining the method column_type over this:
def setup
@column_type = :json
super
endI'm happy to use an instance variable instead if you prefer.
|
@senny Rebased against master. Test are passing. It's ready for prime time! |
|
👍 |
[Philippe Creux, Chris Teague]
Add support for Postgresql JSONB
|
thanks guys 💛 |
|
Thanks for jsonb support 💙 |
This is the updated version of #15195 and #15950 by @pcreux and @chris-teague.
It is tested against postgresql-9.4beta.
Test cases shared between json and jsonb are extracted to a module called
PostgresqlJSONSharedTestCases. I made my best to minimise the amount of lines impacted by this extraction.