Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate source_macro #16373

Merged

Conversation

@eileencodes
Copy link
Member

@eileencodes eileencodes commented Aug 2, 2014

source_macro is no longer used in any Active Record code. I've chosen to deprecate it because it was not marked as nodoc and may be in use outside of rails source.

If we prefer to remove it I can alter the PR

See #16353 for how it is no longer used.

`source_macro` is no longer used in any ActiveRecord code. I've
chosen to deprecate it because it was not marked as nodoc and may
be in use outside of rails source.
rafaelfranca added a commit that referenced this pull request Aug 2, 2014
…e_macro

Deprecate source_macro
@rafaelfranca rafaelfranca merged commit 8dda066 into rails:master Aug 2, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
def source_macro; macro; end
def source_macro
ActiveSupport::Deprecation.warn("ActiveRecord::Base.source_macro is deprecated and " \
"will be removed without replacement.")

This comment has been minimized.

@arthurnn

arthurnn Aug 2, 2014
Member

should we advice to use AR::Base.macro ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.