Deprecate source_macro #16373

Merged
merged 1 commit into from Aug 2, 2014

Conversation

Projects
None yet
3 participants
@eileencodes
Member

eileencodes commented Aug 2, 2014

source_macro is no longer used in any Active Record code. I've chosen to deprecate it because it was not marked as nodoc and may be in use outside of rails source.

If we prefer to remove it I can alter the PR

See #16353 for how it is no longer used.

Deprecate source_macro
`source_macro` is no longer used in any ActiveRecord code. I've
chosen to deprecate it because it was not marked as nodoc and may
be in use outside of rails source.

rafaelfranca added a commit that referenced this pull request Aug 2, 2014

@rafaelfranca rafaelfranca merged commit 8dda066 into rails:master Aug 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
- def source_macro; macro; end
+ def source_macro
+ ActiveSupport::Deprecation.warn("ActiveRecord::Base.source_macro is deprecated and " \
+ "will be removed without replacement.")

This comment has been minimized.

@arthurnn

arthurnn Aug 2, 2014

Member

should we advice to use AR::Base.macro ?

@arthurnn

arthurnn Aug 2, 2014

Member

should we advice to use AR::Base.macro ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment