Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename MiniTest to Minitest #16374

Merged
merged 1 commit into from Aug 2, 2014
Merged

Conversation

Rajarshi Das
@robin850

This comment has been minimized.

Copy link
Member

robin850 commented Aug 2, 2014

Hello @rajcybage,

Thanks for the patch but this kind of patch falls under the "cosmetic changes" category, sorry!

@robin850 robin850 closed this Aug 2, 2014
@vipulnsward

This comment has been minimized.

Copy link
Member

vipulnsward commented Aug 2, 2014

@robin850 7bae292
We should follow one style of usage, and not use the deprecated one.

@robin850

This comment has been minimized.

Copy link
Member

robin850 commented Aug 2, 2014

Well at least #13366 has been merged and they are the last occurrences of MiniTest in the code so why not ; sorry ! :-)

@robin850 robin850 reopened this Aug 2, 2014
rafaelfranca added a commit that referenced this pull request Aug 2, 2014
rename MiniTest to Minitest
@rafaelfranca rafaelfranca merged commit ffd5ec8 into rails:master Aug 2, 2014
1 check was pending
1 check was pending
continuous-integration/travis-ci The Travis CI build is in progress
Details
@zenspider

This comment has been minimized.

Copy link
Contributor

zenspider commented Aug 3, 2014

Really not cosmetic. Thanks for merging. Sorry I missed these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.