Fix in has_secure_password for passwords containing only spaces.#16412
Fix in has_secure_password for passwords containing only spaces.#16412spastorino merged 1 commit intorails:masterfrom yevhene:master
Conversation
There was a problem hiding this comment.
To forbid passwords contains only spaces, and give relevant error message.
|
Not sure if we need actually want to block blank passwords. It seems like the original code was written this way to catch the |
|
I think it would be reasonable behavior, if we accept spaces as any other char. |
|
seems good to me! can you add a changelog along the lines of "Fixed (what wasn't working). (Offer suggestion for those who preferred the original behavior)."? 😄 |
|
Also, can you squash your commits? |
Fix in has_secure_password for passwords containing only spaces.
|
Not sure if this is the commit to blame as I migrated from |
Steps: