Make tests stronger, cleaner and slimmer #1647

Merged
merged 3 commits into from Jun 11, 2011

3 participants

@neerajdotname
Ruby on Rails member

No description provided.

Neeraj Singh added some commits Jun 10, 2011
Neeraj Singh try not to use assert_blank when nil will would
be considered as failure

Test for specific value to the extent possible
5da89af
Neeraj Singh expected message should come first 6688b63
Neeraj Singh remove meaningless assert true f3c9f32
@drogus drogus commented on the diff Jun 11, 2011
actionpack/test/controller/test_test.rb
@@ -612,7 +612,6 @@ XML
send(method, :test_remote_addr)
assert false, "expected RuntimeError, got nothing"
rescue RuntimeError => error
- assert true
@drogus
Ruby on Rails member
drogus added a note Jun 11, 2011

I have doubts, it seems to be really important :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@drogus drogus closed this Jun 11, 2011
@josevalim josevalim reopened this Jun 11, 2011
@josevalim josevalim merged commit 1829dd9 into rails:master Jun 11, 2011
@jake3030 jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011
@yaroslav yaroslav Refactor ActiveRecord::Base#new_record? [#1647 state:committed]
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
28347d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment