Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated ActionMailer .deliver and updated ActionMailer / ActiveJob docs/guide #16582

Merged

Conversation

cristianbica
Copy link
Member

@cristianbica cristianbica commented Aug 20, 2014

@cristianbica cristianbica force-pushed the actionmailer-deprecate-deliver branch 2 times, most recently from b4d86b3 to a1611c3 Compare Aug 20, 2014
@@ -1,45 +1,117 @@
require 'delegate'

module ActionMailer

# The ActionMailer::MessageDeliver class is used by ActionMailer::Base when creating a new mailer. You
# should not instantiate MessageDelivery directly. MessageDeliver is a wrapper (Delegator subclass)
Copy link
Member

@rafaelfranca rafaelfranca Aug 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is better to remove the part where we enforce that users should not create it. If users want to create they will despite our recommendation or not 😄. Also the initialize method is already with nodoc.

@cristianbica cristianbica force-pushed the actionmailer-deprecate-deliver branch from a1611c3 to 9e7f4a9 Compare Aug 20, 2014
@cristianbica
Copy link
Member Author

cristianbica commented Aug 20, 2014

@rafaelfranca fixed all your comments

rafaelfranca added a commit that referenced this pull request Aug 20, 2014
…liver

Deprecated ActionMailer .deliver and updated ActionMailer / ActiveJob docs/guide
@rafaelfranca rafaelfranca merged commit 0baed94 into rails:master Aug 20, 2014
@cristianbica cristianbica deleted the actionmailer-deprecate-deliver branch Aug 24, 2014
reefdog added a commit to documentcloud/documentcloud that referenced this pull request Apr 28, 2016
`deliver` has been deprecated and will be removed in Rails 5: rails/rails#16582

Closes #385
alimi added a commit to Kajabi/devise-async that referenced this pull request Oct 19, 2020
  * ActionMailer#deliver has been deprecated in favor of
    #deliver_now/#deliver_later. See rails/rails#16582.
  * Since #deliver is being called in a job, change it to #deliver_now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants