Deprecated ActionMailer .deliver and updated ActionMailer / ActiveJob docs/guide #16582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianbica
force-pushed
the
actionmailer-deprecate-deliver
branch
2 times, most recently
from
b4d86b3 to
a1611c3
Compare
| @@ -1,45 +1,117 @@ | |||
| require 'delegate' | |||
|
|
|||
| module ActionMailer | |||
|
|
|||
| # The ActionMailer::MessageDeliver class is used by ActionMailer::Base when creating a new mailer. You | |||
| # should not instantiate MessageDelivery directly. MessageDeliver is a wrapper (Delegator subclass) | |||
There was a problem hiding this comment.
I believe it is better to remove the part where we enforce that users should not create it. If users want to create they will despite our recommendation or not 😄. Also the initialize method is already with nodoc.
cristianbica
force-pushed
the
actionmailer-deprecate-deliver
branch
from
a1611c3 to
9e7f4a9
Compare
|
@rafaelfranca fixed all your comments |
rafaelfranca
added a commit
that referenced
this pull request
Aug 20, 2014
…liver Deprecated ActionMailer .deliver and updated ActionMailer / ActiveJob docs/guide
reefdog
added a commit
to documentcloud/documentcloud
that referenced
this pull request
Apr 28, 2016
`deliver` has been deprecated and will be removed in Rails 5: rails/rails#16582 Closes #385
alimi
added a commit
to Kajabi/devise-async
that referenced
this pull request
Oct 19, 2020
* ActionMailer#deliver has been deprecated in favor of
#deliver_now/#deliver_later. See rails/rails#16582.
* Since #deliver is being called in a job, change it to #deliver_now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SomeMailer.some_email(*args).deliveris deprecated in favour of.deliver_now. (context Allow config options to deliver all emails async (through activejob) #16549)