Skip to content

Conversation

@nanaya
Copy link
Contributor

@nanaya nanaya commented Aug 23, 2014

I'm not sure how to style it though.

(Extra bit)
And looking again, it's weird because the validation is set on attribute but the error is set on different attribute: attribute_confirmation - inconsistent with other built in validations as far as I can tell.

senny added a commit that referenced this pull request Aug 27, 2014
Update documentation to match change in #5942 [ci skip]
@senny senny merged commit bf44481 into rails:master Aug 27, 2014
@senny
Copy link
Member

senny commented Aug 27, 2014

@edogawaconan looks reasonable. The validation is not set on attribute_confirmation because the validator actually creates that as a virtual attribute. Why the error is set on the confirmation attribute is described in #5942. It's not optimal but probably does what you'd expect.

Thank you 💛

@nanaya nanaya deleted the doc-fix branch August 27, 2014 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants