Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --skip-action-view option from application generator #17042

Merged
merged 1 commit into from Sep 24, 2014

Conversation

@DanOlson
Copy link
Contributor

DanOlson commented Sep 23, 2014

Removes the --skip-action-view option when generating a new app using rails new. Fixes #17023.

@@ -9,7 +9,6 @@
<%= comment_if :skip_active_record %>require "active_record/railtie"
require "action_controller/railtie"
require "action_mailer/railtie"
<%= comment_if :skip_action_view %>require "action_view/railtie"

This comment has been minimized.

Copy link
@rafaelfranca

rafaelfranca Sep 24, 2014

Member

We should only remove the comment_if call. We still need to require the action view railtie.

This comment has been minimized.

Copy link
@DanOlson

DanOlson Sep 24, 2014

Author Contributor

Of course, thank you. Fixed.

@DanOlson DanOlson force-pushed the DanOlson:remove-skip-action-view branch to 8e9bc11 Sep 24, 2014
rafaelfranca added a commit that referenced this pull request Sep 24, 2014
Remove --skip-action-view option from application generator
@rafaelfranca rafaelfranca merged commit 2bb0fcb into rails:master Sep 24, 2014
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details
@DanOlson DanOlson deleted the DanOlson:remove-skip-action-view branch Sep 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.