Remove --skip-action-view option from application generator #17042

Merged
merged 1 commit into from Sep 24, 2014

Conversation

Projects
None yet
2 participants
@DanOlson
Contributor

DanOlson commented Sep 23, 2014

Removes the --skip-action-view option when generating a new app using rails new. Fixes #17023.

@@ -9,7 +9,6 @@
<%= comment_if :skip_active_record %>require "active_record/railtie"
require "action_controller/railtie"
require "action_mailer/railtie"
-<%= comment_if :skip_action_view %>require "action_view/railtie"

This comment has been minimized.

@rafaelfranca

rafaelfranca Sep 24, 2014

Member

We should only remove the comment_if call. We still need to require the action view railtie.

@rafaelfranca

rafaelfranca Sep 24, 2014

Member

We should only remove the comment_if call. We still need to require the action view railtie.

This comment has been minimized.

@DanOlson

DanOlson Sep 24, 2014

Contributor

Of course, thank you. Fixed.

@DanOlson

DanOlson Sep 24, 2014

Contributor

Of course, thank you. Fixed.

rafaelfranca added a commit that referenced this pull request Sep 24, 2014

Merge pull request #17042 from DanOlson/remove-skip-action-view
Remove --skip-action-view option from application generator

@rafaelfranca rafaelfranca merged commit 2bb0fcb into rails:master Sep 24, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@DanOlson DanOlson deleted the DanOlson:remove-skip-action-view branch Sep 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment