Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --skip-action-view option from application generator #17042

Merged
merged 1 commit into from Sep 24, 2014

Conversation

DanOlson
Copy link
Contributor

@DanOlson DanOlson commented Sep 23, 2014

Removes the --skip-action-view option when generating a new app using rails new. Fixes #17023.

@@ -9,7 +9,6 @@
<%= comment_if :skip_active_record %>require "active_record/railtie"
require "action_controller/railtie"
require "action_mailer/railtie"
<%= comment_if :skip_action_view %>require "action_view/railtie"
Copy link
Member

@rafaelfranca rafaelfranca Sep 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only remove the comment_if call. We still need to require the action view railtie.

Copy link
Contributor Author

@DanOlson DanOlson Sep 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, thank you. Fixed.

@DanOlson DanOlson force-pushed the remove-skip-action-view branch from 7ea7d6e to 8e9bc11 Compare Sep 24, 2014
rafaelfranca added a commit that referenced this pull request Sep 24, 2014
Remove --skip-action-view option from application generator
@rafaelfranca rafaelfranca merged commit 2bb0fcb into rails:master Sep 24, 2014
@DanOlson DanOlson deleted the remove-skip-action-view branch Sep 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The app generator's --skip-action-view option means nothing
2 participants