Bring try! into parity with try.

[aripollak]

Based on commit 5e51bdd.

[chancancode]

Wouldn't we need the arity test here?

class A
  def lol(obj)
    obj.try { |thing| call_me_maybe; thing.call_me_maybe }
  end

  def call_me_maybe
    puts 'method in class A'
  end
end

class B
  def call_me_maybe
    puts 'method in class B'
  end
end

A.new.lol(B.new)

I believe that your patch would change this behavior (would be nice if you could add a test like this for both try and try!)

[chancancode]

Nvm, I missed that you are just delegating to try

[chancancode]

In case anyone is wondering about the same thing..

I saw that the original implementation was duplicated from try instead of delegated like what @amatsuda implemented here, so I was wondering if that's done for performance reasons.

Turns out that the difference is very small, almost smaller than what the benchmark library is capable of measuring. If you find anything wrong with my benchmarks feel free to open a new issue/PR 😄

[aripollak]

It occurs to me now that it probably makes more sense to do the delegation the other way around, and just have try do the extra respond_to check. I'll look into making another PR.

[chancancode]

@aripollak 👍