Fix several warnings: change version of nokogiri gem #1738

Merged
merged 1 commit into from Jun 16, 2011

Conversation

Projects
None yet
2 participants
@gazay
Contributor

gazay commented Jun 16, 2011

When you run 'rake test' there are several warnings about mismatched indentations at 'end' and 'def' or 'module' etc:

/Users/gazay/code/rails/actionpack/lib/action_dispatch/routing/mapper.rb:90: warning: mismatched indentations at 'end' with 'def' at 69
/Users/gazay/.rvm/gems/ruby-1.9.2-p180/gems/nokogiri-1.4.4/lib/nokogiri/css/generated_parser.rb:675: warning: mismatched indentations at 'end' with 'module' at 11

So the problem was in nokogiri gem 1.4.4 version, i found it was fixed (https://github.com/tenderlove/nokogiri/commit/f1e3133b0c689e619964217e2a5b3e055bbb2cc7) and bumped version to 1.4.5 stable. I suggest change version in Gemfile to 1.4.5, it solves this problem.

spastorino added a commit that referenced this pull request Jun 16, 2011

Merge pull request #1738 from gazay/3-1-stable-change-nokogiri-version
Fix several warnings: change version of nokogiri gem

@spastorino spastorino merged commit da25aa5 into rails:master Jun 16, 2011

jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011

Cache columns for has_and_belongs_to_many associations
This avoids repeatedly calling SHOW COLUMNS when the association is queried
[#1738 state:committed]

jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment