Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix inconsistencies with serving images in production mode when ActiveRecord is loaded #1764

Merged
merged 1 commit into from Jun 19, 2011

Conversation

Projects
None yet
2 participants
Contributor

stevehodgkiss commented Jun 18, 2011

Fix inconsistencies by being polite to the wrapped body. Needed for Rack::Sendfile to function properly. See issue #1761.

When active record isn't loaded assets aren't served in production mode, when it is loaded they are... It's debatable whether this is a bug or a feature, but I think it should behave the same whether active record is loaded or not :)

@josevalim josevalim added a commit that referenced this pull request Jun 19, 2011

@josevalim josevalim Merge pull request #1764 from stevehodgkiss/master
Fix inconsistencies with serving images in production mode when ActiveRecord is loaded
4054435

@josevalim josevalim merged commit 4054435 into rails:master Jun 19, 2011

Contributor

josevalim commented Jun 19, 2011

Could you please provide a pull request for 3-1-stable?

@josevalim josevalim merged commit 5044420 into rails:master Jun 19, 2011

@jake3030 jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011

@pixeltrix @josh pixeltrix + josh Use Path rather than EagerPath when cache_classes == false so other v…
…iew paths are properly recompiled in development mode [#1764 state:resolved]

Signed-off-by: Joshua Peek <josh@joshpeek.com>
bccd2c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment