Updated rake:notes to search additional directories #1767

merged 1 commit into from Jul 7, 2011


None yet
4 participants

jwarwick commented Jun 19, 2011

I updated rake:notes to search app, config, lib, public, script, test and vendor dirs.


vijaydev commented Jun 19, 2011

Isn't looking in public useless unless you also include extensions that go in there?


drogus commented Jun 19, 2011

Searching in vendor will very likely result in noise from 3rd party libraries.


jwarwick commented Jun 20, 2011

@vijaydev - Agreed. I'll add support for additional extensions and re-add public/ in a future pull request.

@drogus - Fine point. I've removed vendor/ from the list.

Thanks for taking the time to look at the request.

@jake3030 jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011

@josh josh Ensure any method sent to RewindableIO reads the original IO object [#…
…1767 state:resolved]

spastorino commented Jul 6, 2011

Can you squash your commits in just one?, thanks.


jwarwick commented Jul 7, 2011

Should be squashed into a single commit now.

@spastorino spastorino added a commit that referenced this pull request Jul 7, 2011

@spastorino spastorino Merge pull request #1767 from jwarwick/rake_notes_dirs
Updated rake:notes to search additional directories

@spastorino spastorino merged commit 99c20aa into rails:master Jul 7, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment