Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 16928, improve reflections public API doc #17718

Merged
merged 2 commits into from Nov 23, 2014
Merged

Conversation

@arthurnn
Copy link
Member

arthurnn commented Nov 23, 2014

two things in here,

  • Add changelog entry for reflections API change
  • Fix public doc for reflections method.

review @rafaelfranca @matthewd

arthurnn added 2 commits Nov 23, 2014
`.reflections` public API changed to return a String instead of a Symbol
as keys.

see commit 1f31488 and 6259e4e

[fixes #16928]
[fixes #17610]
@arthurnn
Copy link
Member Author

arthurnn commented Nov 23, 2014

[fixes #16928]

@zzak
Copy link
Member

zzak commented Nov 23, 2014

LGTM :shipit:

zzak added a commit that referenced this pull request Nov 23, 2014
Fixes 16928, improve reflections public API doc [ci skip]
@zzak zzak merged commit e7bf741 into rails:master Nov 23, 2014
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
@arthurnn arthurnn deleted the arthurnn:fixes_16928 branch Nov 24, 2014
arthurnn added a commit to arthurnn/rails that referenced this pull request Nov 24, 2014
[related rails#17718]
jfragoulis added a commit to jfragoulis/agile_serializer that referenced this pull request Sep 10, 2015
> ActiveRecord::Base#reflections now returns a hash with string keys instead of symbol keys.

[PR] rails/rails#17718
jfragoulis added a commit to jfragoulis/agile_serializer that referenced this pull request Sep 11, 2015
Update the code that uses the internal rails api to be compatible with rails 4.2.

> ActiveRecord::Base#reflections now returns a hash with string keys instead of symbol keys.

[PR] rails/rails#17718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.