Fixes 16928, improve reflections public API doc #17718

Merged
merged 2 commits into from Nov 23, 2014

Conversation

Projects
None yet
2 participants
@arthurnn
Member

arthurnn commented Nov 23, 2014

two things in here,

  • Add changelog entry for reflections API change
  • Fix public doc for reflections method.

review @rafaelfranca @matthewd

arthurnn added some commits Nov 23, 2014

Add changelog entry for .reflections API change
`.reflections` public API changed to return a String instead of a Symbol
as keys.

see commit 1f31488 and 6259e4e

[fixes #16928]
[fixes #17610]
@arthurnn

This comment has been minimized.

Show comment
Hide comment
@arthurnn

arthurnn Nov 23, 2014

Member

[fixes #16928]

Member

arthurnn commented Nov 23, 2014

[fixes #16928]

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Nov 23, 2014

Member

LGTM :shipit:

Member

zzak commented Nov 23, 2014

LGTM :shipit:

zzak added a commit that referenced this pull request Nov 23, 2014

Merge pull request #17718 from arthurnn/fixes_16928
Fixes 16928, improve reflections public API doc [ci skip]

@zzak zzak merged commit e7bf741 into rails:master Nov 23, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@arthurnn arthurnn deleted the arthurnn:fixes_16928 branch Nov 24, 2014

arthurnn added a commit to arthurnn/rails that referenced this pull request Nov 24, 2014

sachin004 added a commit to sachin004/rails that referenced this pull request Dec 13, 2014

@seanculver seanculver referenced this pull request in mavenlink/brainstem Dec 24, 2014

Closed

Specs fail on Rails 4.2 #39

jfragoulis pushed a commit to jfragoulis/agile_serializer that referenced this pull request Sep 10, 2015

John Fragoulis
Fix incopatibility presented with 4.2 code
> ActiveRecord::Base#reflections now returns a hash with string keys instead of symbol keys.

[PR] rails/rails#17718

@jfragoulis jfragoulis referenced this pull request in ctrochalakis/agile_serializer Sep 10, 2015

Merged

Fix incompatibility presented with 4.2 code #5

jfragoulis pushed a commit to jfragoulis/agile_serializer that referenced this pull request Sep 11, 2015

John Fragoulis
Fix incompatibility presented with 4.2 code
Update the code that uses the internal rails api to be compatible with rails 4.2.

> ActiveRecord::Base#reflections now returns a hash with string keys instead of symbol keys.

[PR] rails/rails#17718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment