Fixes 16928, improve reflections public API doc#17718
Merged
Merged
Conversation
`.reflections` public API changed to return a String instead of a Symbol as keys. see commit 1f31488 and 6259e4e [fixes rails#16928] [fixes rails#17610]
Member
Author
|
[fixes #16928] |
Member
|
LGTM |
zzak
pushed a commit
that referenced
this pull request
Nov 23, 2014
Fixes 16928, improve reflections public API doc [ci skip]
arthurnn
added a commit
to arthurnn/rails
that referenced
this pull request
Nov 24, 2014
fragoulis
added a commit
to fragoulis/agile_serializer
that referenced
this pull request
Sep 10, 2015
> ActiveRecord::Base#reflections now returns a hash with string keys instead of symbol keys. [PR] rails/rails#17718
fragoulis
added a commit
to fragoulis/agile_serializer
that referenced
this pull request
Sep 11, 2015
Update the code that uses the internal rails api to be compatible with rails 4.2. > ActiveRecord::Base#reflections now returns a hash with string keys instead of symbol keys. [PR] rails/rails#17718
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two things in here,
reflectionsmethod.review @rafaelfranca @matthewd