Remove custom errors page section from the guides #17815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki24
force-pushed
the
remove-custom-errors-page-section
branch
from
539d7e2
to
a4f9479
Compare
|
Yep, we generally don't link to external material, gems, videos, talks, etc. |
|
Yeah, I don't think linking is a good idea at this point. I'll remove it. |
This pattern is too problematic and introduces a lot of edge cases: * On 4.2, the issue rails#15124 is back again. * needs to define each action for each http status otherwise the router raises ActionController::RoutingError (No route matches). * If the router has `match "/*username",...` and some action is missing, Rails will pick up the "match" and try to do its job. * encourages people to copy & paste programming. Not DRY. [ci skip]
yuki24
force-pushed
the
remove-custom-errors-page-section
branch
from
a4f9479
to
cbcec99
Compare
|
updated. |
|
Any chance to get this merged into master and 4-2-stable? I really don't want any more people to follow this pattern. |
|
@rafaelfranca Sorry for pushing this again, but please do consider merging this before 4.2.0 is out. |
zzak
pushed a commit
that referenced
this pull request
Dec 11, 2014
Remove custom errors page section from the guides [ci skip]
zzak
pushed a commit
that referenced
this pull request
Dec 11, 2014
Remove custom errors page section from the guides [ci skip]
|
@yuki24 committed and backported in 11bbf15 @rafaelfranca What is |
|
@zzak Thanks! |
|
@zzak it is the release branch. The release will be done from that branch. You should backport it too. |
h-lame
added a commit
to alphagov/transition
that referenced
this pull request
Mar 16, 2016
As of rails 4.2 it's no longer mentioned in the guide as something to consider doing to get dynamic error pages. See: rails/rails#17815 Setting an exceptions_app is still documented, but setting it to self.routes is not. It still works for us, but we should be aware that this might be a blocker to future upgrades.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pattern is error-prone and introduces a lot of edge cases:
ActionController::RoutingError (No route matches).match "/*username",...and an error page action is missing, Rails would pick up the "match" route and try to render the user's page.I've seen many people who have done this, most of which have run into an issue. I believe we should stop doing
config.exceptions_app = self.routesand use static error pages, or use the rambulance gem as a temporary solution.