Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding method chaining section on ActiveRecord querying guide [ci skip] #18034

Merged
merged 1 commit into from Dec 16, 2014
Merged

Adding method chaining section on ActiveRecord querying guide [ci skip] #18034

merged 1 commit into from Dec 16, 2014

Conversation

andreynering
Copy link
Contributor

A better alternative to #17750

@rafaelfranca
Copy link
Member

Thank you for the pull request.

I believe the same answer still applies here #17750 (comment).

Why do we need to talk about this for join but not for all, where or any method that returns a collection?

@andreynering
Copy link
Contributor Author

@rafaelfranca Is there a better place to put this?

Joining to find a single record is a common need (I think). I thought in putting this in the guides because I had this doubt in the past. The guides do not cover this until now.

I think someone needing to use find with where or all is not much common.

@rafaelfranca
Copy link
Member

I think someone needing to use find with where or all is not much common.

It is far more common that using with join. Chaining Active Record finders is something that should be documented independent of which finder method is being used since it applies to a huge number of methods.

If we are going to document such thing we should document as a new section and not in a specific use case.

@rafaelfranca
Copy link
Member

Ooops. Closed by accident

@andreynering andreynering changed the title Adding a tip about the possibility to get a single record with '.join' [ci skip] Adding method chaining section on ActiveRecord querying guide [ci skip] Dec 15, 2014
@andreynering
Copy link
Contributor Author

@rafaelfranca What about?

zzak pushed a commit that referenced this pull request Dec 16, 2014
Adding method chaining section on ActiveRecord querying guide [ci skip]
@zzak zzak merged commit 7a7f44d into rails:master Dec 16, 2014
zzak pushed a commit to zzak/rails that referenced this pull request Dec 16, 2014
@andreynering andreynering deleted the ar-guides-querying branch December 16, 2014 10:07
@rafaelfranca
Copy link
Member

Very good ❤️ 💚 💙 💛 💜

sivagollapalli pushed a commit to sivagollapalli/rails that referenced this pull request Dec 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants