Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow static asset serving from env variable (enhanced!) #18100
This is awesome, i can dig this deprecation. Originally i was worried that something like this:
Would be harder do deal with on Heroku (docker et. al.). Basically we can set a default environment variable but it is difficult to unset an environment variable (using a .profile.d script). That's why my original patch checked for
Yeah, decided that it's probably not worth going down the "parsing from an ENV var rabbit hole" ("false", "0", "NO", "FALSE", "OMG_PLEASE_DONT"
Thanks for bearing with us and sorry that it was so difficult!