Remove ActionController::ModelNaming #18194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods in these modules are not used anywhere. They used to be invoked in polymorphic_routes.rb but their usage was removed in e821045. What is your opinion about removing these methods? They do belong to the public API, but in reality their code has already been duplicated to ActionView::ModelNaming, since they are used by methods like `dom_id` and `dom_class` to associated records with DOM elements (in ActionView). Please tell me if you think that removing this module is a good idea and, in that case, if the PR is okay as it is, or you'd rather start by showing a deprecation message, and remove the module in Rails 5.1.
|
We need some form of deprecation warning. Also go spend time with your family, this shit can wait. 😁 |
|
merry xmas!!! |
|
Merry 🎄 to you all! 🎅 |
|
Sorry, this was never supposed to be public, I forgot to mark it as private when I added it in 166dbaa I've looking on Google and Github to check if someone really is using one of the methods inside of AC::Naming and I'm pretty sure no one is doing it and since 5.0 is a major release I think is reasonable to remove this without deprecation. |
guilleiguaran
added a commit
that referenced
this pull request
Dec 26, 2014
…l-naming Remove ActionController::ModelNaming
|
👍 |
prathamesh-sonpatki
added a commit
to prathamesh-sonpatki/rails
that referenced
this pull request
Jun 7, 2016
prathamesh-sonpatki
added a commit
to prathamesh-sonpatki/rails
that referenced
this pull request
Jun 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods in these modules are not used anywhere.
They used to be invoked in
polymorphic_routes.rbbut their last usage was removed in e821045.What is your opinion about removing these methods?
They do belong to the public API, but in reality their code has already been duplicated into
ActionView::ModelNaming.The ActionView module is still used (by
dom_idanddom_classto associate records with DOM elements).The ActionController module is not.
Please tell me if you think that removing this module is a good idea and if you feel like the PR is okay as it is, or whether some deprecation warning should be displayed.