Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove ActionController::ModelNaming #18194
The methods in these modules are not used anywhere.
What is your opinion about removing these methods?
The ActionView module is still used (by
Please tell me if you think that removing this module is a good idea and if you feel like the PR is okay as it is, or whether some deprecation warning should be displayed.
The methods in these modules are not used anywhere. They used to be invoked in polymorphic_routes.rb but their usage was removed in e821045. What is your opinion about removing these methods? They do belong to the public API, but in reality their code has already been duplicated to ActionView::ModelNaming, since they are used by methods like `dom_id` and `dom_class` to associated records with DOM elements (in ActionView). Please tell me if you think that removing this module is a good idea and, in that case, if the PR is okay as it is, or you'd rather start by showing a deprecation message, and remove the module in Rails 5.1.
Sorry, this was never supposed to be public, I forgot to mark it as private when I added it in 166dbaa
I've looking on Google and Github to check if someone really is using one of the methods inside of AC::Naming and I'm pretty sure no one is doing it and since 5.0 is a major release I think is reasonable to remove this without deprecation.