Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the tmp/sessions folder and its clear task #18314

Merged
merged 1 commit into from Jan 3, 2015
Merged

Remove the tmp/sessions folder and its clear task #18314

merged 1 commit into from Jan 3, 2015

Conversation

robin850
Copy link
Member

@robin850 robin850 commented Jan 3, 2015

Hello,

Commit 1aea470 introduced the tmp/sessions directory but this was at a time when the default way to store sessions was on the file system under the tmp directory. It looks like this directory is not needed anymore so let's get rid of it.

Just for the record, this has been spotted by yui-knk in #17564 (comment).

Have a nice day.

Commit 1aea470 introduced this directory but this was at a time when the
default way to store sessions was on the file system under the tmp
directory.

Let's remove references to it from the documentation as well.

[Robin Dupret & yui-knk]
rafaelfranca added a commit that referenced this pull request Jan 3, 2015
Remove the tmp/sessions folder and its clear task
@rafaelfranca rafaelfranca merged commit c2094f5 into rails:master Jan 3, 2015
@robin850 robin850 deleted the rm-tmp-sessions branch Jan 3, 2015
teemukoo pushed a commit to teemukoo/ansible-redmine that referenced this pull request Oct 15, 2020
The update requires removal of an old rake clearing task as well.

The task tmp:sessions:clear has been removed in Redmine 4 (which uses
Rails 5), so it must be removed here as well.
rails/rails#18314

The old task is not referenced in the upgrade documentation anymore.
https://www.redmine.org/projects/redmine/wiki/RedmineUpgrade/82

Perhaps this could have a conditional for different Redmine versions.
teemukoo pushed a commit to teemukoo/ansible-redmine that referenced this pull request Oct 16, 2020
The task tmp:sessions:clear has been removed in Redmine 4 (which uses
Rails 5), so it must be removed here as well.
rails/rails#18314

The old task is not referenced in the upgrade documentation anymore.
https://www.redmine.org/projects/redmine/wiki/RedmineUpgrade/82

Perhaps this could have a conditional for different Redmine versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants