Remove the tmp/sessions folder and its clear task #18314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 1aea470 introduced this directory but this was at a time when the default way to store sessions was on the file system under the tmp directory. Let's remove references to it from the documentation as well. [Robin Dupret & yui-knk]
rafaelfranca
added a commit
that referenced
this pull request
Jan 3, 2015
Remove the tmp/sessions folder and its clear task
prathamesh-sonpatki
added a commit
to prathamesh-sonpatki/rails
that referenced
this pull request
Jun 11, 2016
teemukoo
pushed a commit
to teemukoo/ansible-redmine
that referenced
this pull request
Oct 15, 2020
The update requires removal of an old rake clearing task as well. The task tmp:sessions:clear has been removed in Redmine 4 (which uses Rails 5), so it must be removed here as well. rails/rails#18314 The old task is not referenced in the upgrade documentation anymore. https://www.redmine.org/projects/redmine/wiki/RedmineUpgrade/82 Perhaps this could have a conditional for different Redmine versions.
teemukoo
pushed a commit
to teemukoo/ansible-redmine
that referenced
this pull request
Oct 16, 2020
The task tmp:sessions:clear has been removed in Redmine 4 (which uses Rails 5), so it must be removed here as well. rails/rails#18314 The old task is not referenced in the upgrade documentation anymore. https://www.redmine.org/projects/redmine/wiki/RedmineUpgrade/82 Perhaps this could have a conditional for different Redmine versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Commit 1aea470 introduced the
tmp/sessionsdirectory but this was at a time when the default way to store sessions was on the file system under thetmpdirectory. It looks like this directory is not needed anymore so let's get rid of it.Just for the record, this has been spotted by yui-knk in #17564 (comment).
Have a nice day.