Deprecate ActiveModel::Errors get, set and []= methods.

[morgoth]

They have inconsistent behaviour currently.

As discussed in #18631

Do you think we can go further and deprecate also add_on_blank and add_on_empty?
Not sure what is the usecase for them and it's easy enough to write it on your own when needed.

[egilburg]

In complex service objects, we use add_on_empty quite a lot, as there are several pathways that may lead to the same error key being set, and I don't want the same error populated multiple times and dumped as redundant text on user validation error display. Sure I could write my own check, but why not keep this simple helper?

[rafaelfranca]

Does it need to call delete?

[morgoth]

It doesn't need to - already fixed.

[morgoth]

@egilburg I can see that add_on_empty is a "light" version of PresenceValidator, but add_on_blank is exactly the same as PresenceValidator, so maybe at least this one can be deprecated?

[egilburg]

Huh? I thought add on empty means add error if model doesn't have already error with that key.

Eugene

On Jan 22, 2015, at 11:23 AM, Wojciech Wnętrzak notifications@github.com wrote:

@egilburg I can see that add_on_empty is a "light" version of PresenceValidator, but add_on_blank is exactly the same, so maybe at least this one can be deprecated?

—
Reply to this email directly or view it on GitHub.

[morgoth]

@egilburg Nope, it adds :empty error when given value is empty.

u = User.new
u.errors.add(:email, :invalid)
u.errors.add_on_empty(:email)
# => [:email]
u.errors.full_messages
# => ["Email is invalid", "Email can't be empty"]

It also adds this error when value is nil, so it behaves almost exactly as add_on_blank

[morgoth]

@egilburg Did I understand you correctly, that you misused add_on_empty method? If yes, would you agree now on deprecating it?

[egilburg]

@morgoth yes it doesn't seem to be what I thought it is.

[morgoth]

@rafaelfranca this PR is good to go. WDYT about deprecating add_on_empty and add_on_blank as stated above?

[rafaelfranca]

Yeah, let deprecated those methods too.

[chancancode]

For people coming here from This week in Rails, see f55bfe7.

Summary:

• ✅ model.errors[:name]
• ✅ model.errors.add(:name, ...)
• 👎 model.errors.get(:name)
• 👎 model.errors.set(:name, ...)
• 👎 model.errors[:name] = ...