Add `ActiveSupport::Testing::FileFixtures`. by senny · Pull Request #18658 · rails/rails

senny · 2015-01-23T14:51:36Z

It's a thin layer to provide easy access to sample files throughout
test-cases. This adds the directory test/fixtures/files to newly
generated applications.

This is something that came up in a discussion with @dhh

Most of our applications have helpers to access some kind of sample files. Possible use-cases are:

Test file uploads
Sample output to compare generated documents (.csv, .docx, .pdf, ...)
content used in test-cases like xml snippets.
...

senny · 2015-01-23T14:53:05Z

@carlosantoniodasilva @rafaelfranca @dhh interested to hear your thoughts.

The method names feel a bit awkward to me but it's the best I could come up with.

arthurnn · 2015-01-23T18:18:52Z

🆒

vipulnsward · 2015-01-23T18:29:43Z

Nice. @senny it would be awesome if this could be extended to support passing a file in controller requests in tests. Thoughts?

rafaelfranca · 2015-01-23T18:43:11Z

Seems good to me.

robin850 · 2015-01-25T10:51:00Z

Nit-picky thing but it should be "Returns" here, no ?

carlosantoniodasilva · 2015-01-26T15:29:43Z

How about: fixture_path + "files"?

carlosantoniodasilva · 2015-01-26T15:33:06Z

I wonder if we should touch fixture_file_upload to make use of this new files directory rather than the normal fixtures_path in this case?

Other than that it seems good to me, good to have something simple builtin to help with that.

senny · 2015-01-28T08:42:13Z

I changed the configuration option to file_fixture_path and the methods to file_fixture and file_fixture_content.

@carlosantoniodasilva what do you think?

carlosantoniodasilva · 2015-01-28T09:43:36Z

Cool, I like it better 👍, do you prefer like this?

Would you think that leaving the "read" logic for the developers wouldn't be fine? I mean, we could use file_fixture('zomg.txt').read directly on the tests, and only introduce this helper method with the config.

senny · 2015-01-28T09:49:51Z

@carlosantoniodasilva 👍 I think we can get rid of _content and delegate .read to the user. I'll try to cover it in the documentation. Once that base-layer is merged we can start talking about fixture_file_upload.

carlosantoniodasilva · 2015-01-28T09:54:23Z

Alright, great 👍 ❤️

senny · 2015-01-28T10:13:59Z

@carlosantoniodasilva mind a final 👀?

carlosantoniodasilva · 2015-01-28T11:09:55Z

s/they provide/it provides ?

carlosantoniodasilva · 2015-01-28T11:12:58Z

💚💛❤️💙💜

It's a thin layer to provide easy access to sample files throughout test-cases. This adds the directory `test/fixtures/files` to newly generated applications.

Add `ActiveSupport::Testing::FileFixtures`.

senny · 2015-01-28T11:31:37Z

@carlosantoniodasilva thanks man!!! 💛

carlosantoniodasilva · 2015-01-29T09:30:07Z

thank you 👍 💙

senny added this to the 5.0.0 milestone Jan 23, 2015

senny added the activesupport label Jan 23, 2015

robin850 reviewed Jan 25, 2015
View reviewed changes

senny force-pushed the file_fixtures branch from acdf937 to 56e0f73 Compare January 25, 2015 11:12

carlosantoniodasilva reviewed Jan 26, 2015
View reviewed changes

senny force-pushed the file_fixtures branch 2 times, most recently from 5ae37f7 to 06c7fff Compare January 28, 2015 08:41

senny force-pushed the file_fixtures branch from 06c7fff to 05296ea Compare January 28, 2015 10:13

carlosantoniodasilva reviewed Jan 28, 2015
View reviewed changes

Comment thread activesupport/CHANGELOG.md Outdated

Copy link
Copy Markdown

Member

carlosantoniodasilva Jan 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/they provide/it provides ?

introduce ActiveSupport::Testing::FileFixtures.

d28e5b9

It's a thin layer to provide easy access to sample files throughout test-cases. This adds the directory `test/fixtures/files` to newly generated applications.

senny force-pushed the file_fixtures branch from 05296ea to d28e5b9 Compare January 28, 2015 11:30

senny added a commit that referenced this pull request Jan 28, 2015

Merge pull request #18658 from senny/file_fixtures

58047eb

Add `ActiveSupport::Testing::FileFixtures`.

senny merged commit 58047eb into rails:master Jan 28, 2015

senny deleted the file_fixtures branch January 28, 2015 11:31

senny added a commit that referenced this pull request Jan 29, 2015

reassign file_fixture_path in plugins test_helper.rb. refs #18658.

d88f4bc

rafaelfranca modified the milestones: 5.0.0 [temp], 5.0.0 Dec 30, 2015

Conversation

senny commented Jan 23, 2015

Uh oh!

senny commented Jan 23, 2015

Uh oh!

arthurnn commented Jan 23, 2015

Uh oh!

vipulnsward commented Jan 23, 2015

Uh oh!

rafaelfranca commented Jan 23, 2015

Uh oh!

robin850 Jan 25, 2015

Choose a reason for hiding this comment

Uh oh!

carlosantoniodasilva Jan 26, 2015

Choose a reason for hiding this comment

Uh oh!

senny Jan 26, 2015

Choose a reason for hiding this comment

Uh oh!

carlosantoniodasilva commented Jan 26, 2015

Uh oh!

senny commented Jan 28, 2015

Uh oh!

carlosantoniodasilva commented Jan 28, 2015

Uh oh!

senny commented Jan 28, 2015

Uh oh!

carlosantoniodasilva commented Jan 28, 2015

Uh oh!

senny commented Jan 28, 2015

Uh oh!

carlosantoniodasilva Jan 28, 2015

Choose a reason for hiding this comment

Uh oh!

carlosantoniodasilva commented Jan 28, 2015

Uh oh!

senny commented Jan 28, 2015

Uh oh!

carlosantoniodasilva commented Jan 29, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants