Format the time string according to the precision of the time column #18914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -733,7 +733,7 @@ def register_integer_type(mapping, key, options) # :nodoc: | |||
| end | |||
|
|
|||
| def extract_precision(sql_type) | |||
| if /datetime/ === sql_type | |||
| if /^(?:date)?time/ === sql_type | |||
There was a problem hiding this comment.
Was the missing ^ anchor intentional before?
There was a problem hiding this comment.
It seems the missing ^ anchor not intentional.
If you prefer to shortest pattern, it is possible to match /time/. It is only datetime, timestamp and time to match this in MySQL. These types can have a precision.
http://dev.mysql.com/doc/refman/5.6/en/fractional-seconds.html
kamipo
force-pushed
the
format_time_according_to_precision
branch
4 times, most recently
from
20653ef
to
30f9175
Compare
| @@ -87,7 +87,7 @@ platforms :ruby do | |||
| group :db do | |||
| gem 'pg', '>= 0.18.0' | |||
| gem 'mysql', '>= 2.9.0' | |||
| gem 'mysql2', '>= 0.3.13' | |||
| gem 'mysql2', '>= 0.3.18' | |||
There was a problem hiding this comment.
0.3.18 includes fix msec for time field is not passed. brianmario/mysql2#579
kamipo
force-pushed
the
format_time_according_to_precision
branch
4 times, most recently
from
e628c27
to
2803623
Compare
It is also necessary to format a time column like a datetime column.
kamipo
force-pushed
the
format_time_according_to_precision
branch
from
2803623
to
cddc298
Compare
rafaelfranca
added a commit
that referenced
this pull request
Feb 20, 2015
Format the time string according to the precision of the time column
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
May 3, 2015
Follow up rails#18914.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
May 3, 2015
Follow up rails#18914.
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Apr 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is also necessary to format a time column like a datetime column.