created rake restart task#18965
Merged
Merged
Conversation
Member
|
@hjoo I think you can add some tests for this rake task in |
hjoo
force-pushed
the
rake_restart
branch
2 times, most recently
from
205882c to
41f5c80
Compare
Member
There was a problem hiding this comment.
@hjoo can you remove this extra line. Otherwise I think this is looking good 😄
Fixes rails#18876. Rake restart touches `tmp/restart.txt` to restart application on next request. Updated tests and documentation accordingly.
Contributor
|
Does this task need to depend on the |
Member
|
Yes, it can be dropped |
Member
|
@hjoo can you send a new PR that just does |
Member
|
|
Member
|
Thanks @matthewd it's early here 😁 need moar ☕ |
Contributor
Author
|
Done! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created rake restart task to address issue #18876. Was uncertain if spring restart required if tmp/restart.txt will be on Spring watch list (referencing #18874).