Track Gemfile.lock at the repository

[rafaelfranca]

The main reason is to make bisect easier.

In some points, we have a lot of git dependencies. Since we don't have
the information of which commit we are referring to, bundler get the
latest commit of the master branch of the dependency. This sometimes
returns a version that is not compatible with Rails anymore, making the
tests fail and the harder to identify the commit that introduced a bug.

Also this will make sure that a contributor will always get a set of
dependencies that are passing with our tests.

In our CI server we delete the lock file to make sure we are always
testing against the newest release of our dependencies.

[rafaelfranca]

cc @rails/rails-committers @rails/rails-issues

[sgrif]

👍

[eileencodes]

I like anything that makes bisecting easier 😁 Thanks @rafaelfranca!

[guilleiguaran]

I'm 👍 on this :)

[dhh]

I weighed in before understand the issue on the other ticket, but after Rafael educating me, I'm 👍

[lukaszx0]

I'm in! 👍

On Wed, Feb 18, 2015 at 6:38 PM, David Heinemeier Hansson <
notifications@github.com> wrote:

I weighed in before understand the issue on the other ticket, but after
Rafael educating me, I'm [image: 👍]

—
Reply to this email directly or view it on GitHub
#18992 (comment).

[chancancode]

❤️

[carlosantoniodasilva]

💚💛❤️💙💜

[dmathieu]

💯

[arthurnn]

🎉

[vipulnsward]

We should document, whats acceptable when updating the file in contributing guide.

[arthurnn]

Only issue I see about this is:

This sometimes
returns a version that is not compatible with Rails anymore, making the
tests fail and the harder to identify the commit that introduced a bug.

The test will still fail on travis-ci, and it would be still hard to identify the problem.

[rafaelfranca]

@arthurnn at CI side it will still fail but if it is passing locally we will at least know it is because of of the dependencies.

@vipulnsward good point about documenting. I'll write something.

[arunagw]

👍

[fxn]

🚀

[amatsuda]

🤘

[dalizard]

And what was the reason Gemfile.lock not to be under version control?

P.S. Apologies for extending the topic further...

[rafaelfranca]

@dalizard it was http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

[dalizard]

@rafaelfranca Thanks!